Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2026-03-30 22:02:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix a performance problem exposed when using the view manager plugin. The method apply_state() indirectly does a save_state() whenever a column is repositioned. The view manager can reposition a lot of columns in one go, potentially resulting in *many* calls to save_state(). The fix is to call save_state() once after all the columns have been repositions.

Browse Source 
A second piece of the fix is to add a save_state=True parameter to apply_state(). The caller would set save_state=False if it will call save_state() directly.

See https://www.mobileread.com/forums/showthread.php?t=345554. The thread is rather long.
This commit is contained in:
Charles Haley 2022-03-08 12:09:34 +00:00
parent 240aee0ee5
commit 9270e9b948
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/calibre/gui2/library/views.py
View File

@ -725,7 +725,9 @@ class BooksView(QTableView): # {{{
saved_history)[:max_sort_levels]):
self.sort_by_column_and_order(self.column_map.index(col), order)
def apply_state(self, state, max_sort_levels=3):
def apply_state(self, state, max_sort_levels=3, save_state=True):
# set save_state=False if you will save the state yourself after calling
# this method.
h = self.column_header
cmap = {}
hidden = state.get('hidden_columns', [])
@ -739,13 +741,18 @@ class BooksView(QTableView): # {{{
for col, pos in positions.items():
if col in cmap:
pmap[pos] = col
need_save_state = False
self.column_header.blockSignals(True)
for pos in sorted(pmap.keys()):
col = pmap[pos]
idx = cmap[col]
current_pos = h.visualIndex(idx)
if current_pos != pos:
need_save_state = True
h.moveSection(current_pos, pos)
self.column_header.blockSignals(False)
if need_save_state and save_state:
self.save_state()
# Because of a bug in Qt 5 we have to ensure that the header is actually
# relaid out by changing this value, without this sometimes ghost
# columns remain visible when changing libraries