Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Dont use > to test for non-empty strings

Browse Source
This commit is contained in:
Kovid Goyal 2019-08-21 19:56:30 +05:30
parent ae35cdd814
commit 967006043b
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/calibre/gui2/catalog/catalog_epub_mobi.py
View File

@ -297,7 +297,7 @@ class PluginWidget(QWidget,Ui_Form):
'''
new_source = self.header_note_source_field.currentText()
self.header_note_source_field_name = new_source
if new_source > '':
if new_source:
header_note_source_spec = self.header_note_source_fields[unicode_type(new_source)]
self.header_note_source_field_name = header_note_source_spec['field']
@ -387,14 +387,14 @@ class PluginWidget(QWidget,Ui_Form):
# Init self.merge_source_field_name
self.merge_source_field_name = ''
cs = unicode_type(self.merge_source_field.currentText())
if cs > '':
if cs:
merge_source_spec = self.merge_source_fields[cs]
self.merge_source_field_name = merge_source_spec['field']
# Init self.header_note_source_field_name
self.header_note_source_field_name = ''
cs = unicode_type(self.header_note_source_field.currentText())
if cs > '':
if cs:
header_note_source_spec = self.header_note_source_fields[cs]
self.header_note_source_field_name = header_note_source_spec['field']
@ -433,7 +433,7 @@ class PluginWidget(QWidget,Ui_Form):
'''
new_source = self.merge_source_field.currentText()
self.merge_source_field_name = new_source
if new_source > '':
if new_source:
merge_source_spec = self.merge_source_fields[unicode_type(new_source)]
self.merge_source_field_name = merge_source_spec['field']
if not self.merge_before.isChecked() and not self.merge_after.isChecked():