From 97e006ca55aa9dbf3f1205e8f22a9b264b12d76a Mon Sep 17 00:00:00 2001
From: Matthew Wener <125427297+ConstrictM@users.noreply.github.com>
Date: Mon, 10 Jun 2024 12:10:54 -0400
Subject: [PATCH] Improve Windows VM Setup Instructions

Add Specific VS Packages Required for Building Deps
Add html5lib as a Python Package for Qt-WebEngine Build
Revert "Add Don't Notarize to Window Build Steps"
---
 bypy/windows.conf | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/bypy/windows.conf b/bypy/windows.conf
index 2ca18428e2..289e0c46e2 100644
--- a/bypy/windows.conf
+++ b/bypy/windows.conf
@@ -1,7 +1,26 @@
 # Requires installation of Visual Studio 2022 Community Edition, .NET SDK, WiX Toolset, Git, Ruby (without devkit), NodeJS, Python and Perl
+#
+# Visual Studio 2022 Components:
+# .NET SDK
+# C++ ATL for latest vXXX build tools (x86 & x64)
+# C++ Clang Compiler for Windows
+# C++ CMake tools for Windows
+# C++/CLI support for vXXX build tools
+# Git for Windows (can also be installed from web)
+# MSBuild
+# MSBuild support for LLVM (clang-cl) toolset
+# MSVC vXXX - VS 2022 C++ x64/x86 build tools
+# Python 3 (can also be installed from web)
+# Windows 11 SDK
+#
+# Add the following directories to ENV Path:
+# C:\Program Files (x86)\Microsoft Visual Studio\Installer
+# C:\Program Files\Microsoft Visual Studio\VC\Tools\MSVC\14.40.33807\bin\Hostx64\x64
+# C:\Program Files\Microsoft Visual Studio\VC\Tools\Llvm\bin
+#
 # git.exe must be in PATH. Must have ~120GB available disk space and 24GB RAM to build Qt WebEngine
-# Install certifi in python 3 with:
-# py.exe -m pip install certifi
+# Install certifi and html5lib in python 3 with:
+# py.exe -m pip install certifi html5lib
 # Copy opengl32sw.dll from
 # https://download.qt.io/development_releases/prebuilt/llvmpipe/windows/
 # to C:/mesa/64