Pull from trunk

Changelog.yaml

@@ -4,6 +4,99 @@
 # for important features/bug fixes.
 # Also, each release can have new and improved recipes.
 
+- version: 0.7.20
+  date: 2010-09-24
+
+
+  new features:
+    - title: "Tweak epub feature."
+      type: major
+      description: >
+        "Now you can conveniently browse the contents of an epub, tweak them and rebuild the epub within your calibre library 
+         by right clicking on the book and selecting Tweak ePub. See http://www.mobileread.com/forums/showthread.php?t=99875 
+         for details."
+
+    - title: "Add button to Edit metadata dialog to trim borders from the cover"
+
+    - title: "Kobo driver: Add support for setting the ReadStatus to Read and correctly deal with empty collections"
+
+    - title: "Improved algorithm for removal of hyphens during pre-processing"
+
+    - title: "EPUB metadata: Don't read timestamp value from epubs as I am sick of closing bugs about adding books and having the Date not be today."
+
+    - title: "After bulk edit metadata, reselect previously selected books."
+
+  bug fixes:
+    - title: "Fix regression in 0.7.19 that broke the By Author and By Title category listing in Stanza/Aldiko feeds."
+   
+    - title: "MOBI Output: Fix regression that broke sections list in downloaded periodicals on Kindle for non-english news sources"
+
+    - title: "News download: Rationalize cover processing."
+      tickets: [6852]
+
+    - title: "Cover cache: load images only in the GUI thread to prevent stale files being leftover by set_path due to Windows file locking"
+
+    - title: "Database: Make renaming of folders on case change more robust"
+      tickets: [6914]
+
+    - title: "When adding/replacing files to/in EPUB files, set the GPF bit for all files in the archive, to prevent unzip from complaining in linux"
+      tickets: [6363]
+
+    - title: "Plugin loading: Handle encoding declarations in .py files correctly"
+
+    - title: "MOBI input: Another corner case"
+      tickets: [6909]
+
+    - title: "IPC: Store results file in the calibre temp dir and also dont die if for some reason removing result file fails. Should make adding/saving more robust"
+
+    - title: "Database: Fix regression that caused has_cover to create empty directories unneccessarily"
+
+    - title: "Detection of Alex on unix"
+      tickets: [5900]
+
+    - title: "News download: Don't add inline table of contents when downloading news for the Kindle"
+
+    - title: "Add prologue and epilogue to default chapter detection regex"
+
+    - title: "Kobo driver: Fix issue where books that are read were getting their status reset to Unread"
+
+    - title: "Device drivers: Fix occassional false positive when matching books on device with books in the calibre library"
+
+    - title: "Content server: Making serving of large files more efficient."
+
+    - title: "GUI device detection: Handle case when user yanks connected device before device connection handler is called."
+      tickets: [6864]
+
+    - title: "Strip leading/trailing whitespace when setting metadata using the edit metadata dialog"
+      tickets: [6854]
+
+    - title: "KOBO: Editing the Im_Reading list with SD Card installed fixed"
+      tickets: [6850]
+
+  new recipes:
+    - title: "Neal's Nuze and Popular Science"
+      author: Tony Stegall
+
+    - title: "Rmf24.pl"
+      author: "Tomasz Dlugosz"
+      
+    - title: "Gazeta Pomorska"
+      author: "Richard"
+
+    - title: "Le Journal de Montreal and superesportes"
+      author: "Luciano Furtado"
+
+    - title: "The Marker"
+      author: Marbs
+
+    - title: "Tagesanzeiger"
+      author: noxxx
+ 
+
+  improved recipes:
+    - Danas
+    - Harvard Business Review
+
 - version: 0.7.19
   date: 2010-09-17
 
@@ -61,6 +154,7 @@
 
     - title: "PDB Input: Fix bug in conversion of TOC in some PML files"
 
+
   new recipes:
     - title: "taz.de RSS"
       author: Alexander Schremmer
@@ -272,7 +366,7 @@
   new features:
     - title: "Multiple library support: Various improvements to make using multiple calibre libraries easier."
       type: major
-      desc: >
+      description: >
         "Now, when you switch libraries using the Choose Library button on the toolbar, entries are created in the menu of that button to easily switch to that library in the 
         future. Also, you can now right click on a book in the calibre library and use the 'Copy to library' action to copy the book to another library,
         that you have switched to at least once. The name of the current library is shown in the titlebar.
@@ -280,7 +374,7 @@
 
     - title: "Content server: Allow setting a restriction so that the server shares only some of the books in the library."
       type: major
-      desc: >
+      description: >
         "You can now use a Saved Search as a restiction for the content server, via Preferences->Content Server. This will cause the
         server to share only those books that match the saved search.
         "

resources/content_server/gui.js

@@ -54,7 +54,7 @@ function render_book(book) {
     formats = book.attr("formats").split(",");
     if (formats.length > 0) {
         for (i=0; i < formats.length; i++) {
-            title += '<a title="Download in '+formats[i]+' format" class="format" href="'+format_url(formats[i], id, book.attr("title"))+'">'+formats[i]+'</a>, ';
+            title += '<a title="Download in '+formats[i]+' format" class="format" href="'+format_url(formats[i], id, book.attr("safe_title"))+'">'+formats[i]+'</a>, ';
         }
         title = title.slice(0, title.length-2);
         title += '&nbsp;({0}&nbsp;MB)&nbsp;'.format(size);

resources/recipes/boortz.recipe

@@ -1,4 +1,5 @@
 from calibre.web.feeds.news import BasicNewsRecipe
+from calibre.ebooks.BeautifulSoup import BeautifulSoup, re
 class AdvancedUserRecipe1282101454(BasicNewsRecipe):
     title = 'Nealz Nuze'
     language = 'en'
@@ -6,7 +7,7 @@ class AdvancedUserRecipe1282101454(BasicNewsRecipe):
     description = 'Neal Boortz Show Radio Notes'
     publisher = 'Neal Boortz'
     category = 'news, politics, USA, talkshow'
-    oldest_article = 1
+    oldest_article = 2
     max_articles_per_feed = 100
     linearize_tables = True
     no_stylesheets = True
@@ -14,8 +15,8 @@ class AdvancedUserRecipe1282101454(BasicNewsRecipe):
     
     masthead_url = 'http://boortz.com/images/nuze_logo.gif'
     keep_only_tags    = [
-                         dict(name='div', attrs={'id':['SiteContent']})
-                       #,dict(attrs={'id':['cxArticleText']})
+                         dict(name='td', attrs={'id':['contentWellCell']})
+                     
                         ]
     remove_tags = [
                    dict(name='a', attrs={'class':['blogPermalink']}),

resources/recipes/howtogeek.recipe

@@ -0,0 +1,40 @@
+from calibre.web.feeds.news import BasicNewsRecipe
+class AdvancedUserRecipe1282101454(BasicNewsRecipe):
+    title = 'How To Geek'
+    language = 'en'
+    __author__ = 'TonytheBookworm'
+    description = 'Daily Computer Tips and Tricks'
+    publisher = 'Howtogeek'
+    category = 'PC,tips,tricks'
+    oldest_article = 2
+    max_articles_per_feed = 100
+    linearize_tables = True
+    no_stylesheets = True
+    remove_javascript   = True
+    masthead_url = 'http://blog.stackoverflow.com/wp-content/uploads/how-to-geek-logo.png'
+
+
+
+    remove_tags =[dict(name='a', attrs={'target':['_blank']}),
+                  dict(name='table', attrs={'id':['articleTable']}),
+                  dict(name='div',   attrs={'class':['feedflare']}),
+                  ]
+
+    feeds          = [
+                      ('Tips', 'http://feeds.howtogeek.com/howtogeek')
+
+                    ]
+
+
+
+
+
+
+
+
+
+
+
+
+
+

resources/recipes/jpost_fr.recipe

@@ -0,0 +1,57 @@
+from calibre.web.feeds.news import BasicNewsRecipe
+
+class JerusalemPost(BasicNewsRecipe):
+    title = 'Jerusalem post'
+    language = 'fr'
+    __author__ = 'TonytheBookworm'
+    description = 'The Jerusalem Post (in French)'
+    publisher = 'jpost'
+    category = 'news'
+    oldest_article = 30
+    max_articles_per_feed = 100
+    linearize_tables = True
+    no_stylesheets = True
+    remove_javascript   = True
+
+    masthead_url = 'http://static.jpost.com/JPSITES/images/JFrench/2008/site/jplogo.JFrench.gif'
+
+    remove_tags = [
+                   dict(name='a', attrs={'href':['javascript:window.print()']}),
+                   dict(name='div', attrs={'class':['bot']}),
+
+                   ]
+
+    feeds          = [
+                      ('NEWS', 'http://fr.jpost.com/servlet/Satellite?collId=1216805762036&pagename=JFrench%2FPage%2FRSS'),
+                      ('JFrench En route vers la paix', 'http://fr.jpost.com/servlet/Satellite?collId=1216805762201&pagename=JFrench%2FPage%2FRSS'),
+                      ('JFrench Politique', 'http://fr.jpost.com/servlet/Satellite?collId=1215356737334&pagename=JFrench%2FPage%2FRSS'),
+                      ('JFrench Securite', 'http://fr.jpost.com/servlet/Satellite?collId=1215356737338&pagename=JFrench%2FPage%2FRSS'),
+                      ('JFrench Moyen Orient', 'http://fr.jpost.com/servlet/Satellite?collId=1215356737342&pagename=JFrench%2FPage%2FRSS'),
+                      ('JFrench Diplomatie / Monde', 'http://fr.jpost.com/servlet/Satellite?collId=1215356737346&pagename=JFrench%2FPage%2FRSS'),
+                      ('JFrench Economie / Sciences', 'http://fr.jpost.com/servlet/Satellite?collId=1215356737358&pagename=JFrench%2FPage%2FRSS'),
+                      ('JFrench Societe', 'http://fr.jpost.com/servlet/Satellite?collId=1215356737354&pagename=JFrench%2FPage%2FRSS'),
+                      ('JFrench Opinions', 'http://fr.jpost.com/servlet/Satellite?collId=1215356737350&pagename=JFrench%2FPage%2FRSS'),
+                      ('JFrench Monde juif', 'http://fr.jpost.com/servlet/Satellite?collId=1215356737366&pagename=JFrench%2FPage%2FRSS'),
+                      ('JFrench Culture / Sport', 'http://fr.jpost.com/servlet/Satellite?collId=1215356737362&pagename=JFrench%2FPage%2FRSS')
+                    ]
+    def print_version(self, url):
+        split1 = url.split("cid=")
+        #for testing only -------
+        #print 'SPLIT IS: ', split1
+        #print 'ORG URL IS: ', url
+        #---------------------------
+        idnum = split1[1] # get the actual value of the id article
+        #for testing only --------------------
+        #print 'the idnum is: ', idnum
+        #--------------------------------------
+        print_url = 'http://fr.jpost.com/servlet/Satellite?cid=' + idnum + '&pagename=JFrench%2FJPArticle%2FPrinter'
+        #for testing only -------------------------
+        #print 'PRINT URL IS: ', print_url
+        #------------------------------------------
+        return print_url
+
+    #example of how links should be formated
+    #--------------------------------------------------------------------------------------------------------------
+    #org   version =  http://fr.jpost.com/servlet/Satellite?pagename=JFrench/JPArticle/ShowFull&cid=1282804806075
+    #print version =  http://fr.jpost.com/servlet/Satellite?cid=1282804806075&pagename=JFrench%2FJPArticle%2FPrinter
+    #------------------------------------------------------------------------------------------------------------------

resources/recipes/popscience.recipe

@@ -1,5 +1,5 @@
-import re
 from calibre.web.feeds.news import BasicNewsRecipe
+from calibre.ebooks.BeautifulSoup import BeautifulSoup, re
 
 class AdvancedUserRecipe1282101454(BasicNewsRecipe):
     title = 'Popular Science'
@@ -12,13 +12,11 @@ class AdvancedUserRecipe1282101454(BasicNewsRecipe):
     max_articles_per_feed = 100
     no_stylesheets = True
     remove_javascript = True
+    use_embedded_content = True
     
     masthead_url = 'http://www.raytheon.com/newsroom/rtnwcm/groups/Public/documents/masthead/rtn08_popscidec_masthead.jpg'
     
-    remove_tags = [dict(name='div', attrs={'id':['toolbar','main_supplements']}),
-                   dict(name='span', attrs={'class':['comments']}),
-                   dict(name='div', attrs={'class':['relatedinfo related-right','node_navigation','content2']}),
-                   dict(name='ul', attrs={'class':['item-list clear-block']})]
+               
     feeds          = [
                       
                       ('Gadgets', 'http://www.popsci.com/full-feed/gadgets'),

resources/recipes/scientific_american.recipe

@@ -1,78 +1,91 @@
 #!/usr/bin/env  python
 __license__   = 'GPL v3'
-__copyright__ = '2008, Kovid Goyal kovid@kovidgoyal.net'
-__docformat__ = 'restructuredtext en'
 
-'''
-sciam.com
-'''
 import re
 from calibre.web.feeds.news import BasicNewsRecipe
 
 class ScientificAmerican(BasicNewsRecipe):
     title                 = u'Scientific American'
-    description = u'Popular science. Monthly magazine.'
-    __author__ = 'Kovid Goyal'
+    description           = u'Popular Science. Monthly magazine.'
+    category              = 'science'
+    __author__            = 'Starson17'
+    no_stylesheets        = True
+    use_embedded_content  = False
     language              = 'en'
+    publisher             = 'Nature Publishing Group'
+    remove_empty_feeds    = True
     remove_javascript     = True
-    encoding = 'utf-8'
+    oldest_article        = 30
+    max_articles_per_feed = 100
 
-    def print_version(self, url):
-        return url + '&print=true'
+    conversion_options = {'linearize_tables'  : True
+                        , 'comment'           : description
+                        , 'tags'              : category
+                        , 'publisher'         : publisher
+                        , 'language'          : language
+                        }
+
+    keep_only_tags = [
+                dict(name='h2', attrs={'class':'articleTitle'})
+                ,dict(name='p', attrs={'id':'articleDek'})
+                ,dict(name='p', attrs={'class':'articleInfo'})
+                ,dict(name='div', attrs={'id':['articleContent']})
+                ,dict(name='img', attrs={'src':re.compile(r'/media/inline/blog/Image/', re.DOTALL|re.IGNORECASE)}) 
+                ]
+
+    remove_tags = [dict(name='a', attrs={'class':'tinyCommentCount'})]
 
     def parse_index(self):
         soup = self.index_to_soup('http://www.scientificamerican.com/sciammag/')
-        month = self.tag_to_string(soup.find('p',attrs={'id':'articleDek'}))
-        self.timefmt = ' [%s]'%(' '.join(month.strip().split()[:2]))
+        issuetag = soup.find('p',attrs={'id':'articleDek'})
+        self.timefmt = ' [%s]'%(self.tag_to_string(issuetag))
         img = soup.find('img', alt='Scientific American Magazine', src=True)
         if img is not None:
             self.cover_url = img['src']
-
-        feeds = []
-        for div in soup.findAll('div', attrs={'class':['primaryCol',
-            'secondaryCol']}):
-            current_section = None
-            for tag in div.findAll(['h2', 'ul']):
-                if tag.name == 'h2':
-                    current_section = self.tag_to_string(tag).strip()
-                    self.log('\tFound section:', current_section)
-                elif current_section is not None and tag.name == 'ul':
-                    articles = []
-                    for li in tag.findAll('li'):
-                        t = li.findAll('a',
-                                attrs={'class':lambda x: x != 'thumb'},
-                                href=lambda x: x and 'article.cfm' in x)
-                        if not t:
-                            continue
-                        t = t[-1]
-                        title = self.tag_to_string(t)
-                        url = t['href']
+        features, feeds = [], []
+        for a in soup.find(attrs={'class':'primaryCol'}).findAll('a',attrs={'title':'Feature'}):
+            if a is None: continue
             desc = ''
-                        p = li.find(attrs={'class':'dek'})
-                        if p is not None:
-                            desc = self.tag_to_string(p)
-                        articles.append({'title':title, 'url':url,
-                            'description':desc, 'date':''})
-                        self.log('\t\tFound article:', title, '\n\t\tat', url)
-                    if articles:
-                        feeds.append((current_section, articles))
-                    current_section = None
+            s = a.parent.parent.find(attrs={'class':'dek'})
+            desc = self.tag_to_string(s)
+            article = {
+                    'url' : a['href'],
+                    'title' : self.tag_to_string(a),
+                    'date' : '',
+                    'description' : desc,
+                    }
+            features.append(article)
+        feeds.append(('Features', features))
+        department = []
+        title = None
+        for li in soup.find(attrs={'class':'secondaryCol'}).findAll('li'):
+            if 'department.cfm' in li.a['href']:
+                if department:
+                    feeds.append((title, department))
+                title = self.tag_to_string(li.a)
+                department = []
+            if 'article.cfm' in li.h3.a['href']:
+                article = {
+                        'url' : li.h3.a['href'],
+                        'title' : self.tag_to_string(li.h3.a),
+                        'date': '',
+                        'description': self.tag_to_string(li.p),
+                    }
+                department.append(article)
+        if department:
+            feeds.append((title, department))
         return feeds
 
     def postprocess_html(self, soup, first_fetch):
-        if soup is not None:
-            for span in soup.findAll('span', attrs={'class':'pagination'}):
-                span.extract()
-            if not first_fetch:
-                div = soup.find('div', attrs={'class':'headline'})
-                if div:
-                    div.extract()
-
+        for item in soup.findAll('a'):
+            if 'topic.cfm' in item['href']:
+                item.replaceWith(item.string)
         return soup
 
-    preprocess_regexps = [
-        (re.compile(r'Already a Digital subscriber.*Now</a>', re.DOTALL|re.IGNORECASE), lambda match: ''),
-        (re.compile(r'If your institution has site license access, enter.*here</a>.', re.DOTALL|re.IGNORECASE), lambda match: ''),
-        (re.compile(r'to subscribe to our.*;.*\}', re.DOTALL|re.IGNORECASE), lambda match: ''),
-        (re.compile(r'\)\(jQuery\);.*-->', re.DOTALL|re.IGNORECASE), lambda match: ''),
-        ]
+    extra_css = '''
+                p{font-weight: normal; font-size:small}
+                li{font-weight: normal; font-size:small}
+                .headline p{font-size:x-small; font-family:Arial,Helvetica,sans-serif;}
+                h2{font-size:large; font-family:Arial,Helvetica,sans-serif;}
+                h3{font-size:x-small;font-family:Arial,Helvetica,sans-serif;}
+                '''

src/calibre/ebooks/conversion/preprocess.py

@@ -389,6 +389,7 @@ class HTMLPreProcessor(object):
             if is_pdftohtml:
                 end_rules.append((re.compile(r'<p>\s*(?P<chap>(<[ibu]>){0,2}\s*([A-Z \'"!]{3,})\s*([\dA-Z:]+\s){0,4}\s*(</[ibu]>){0,2})\s*<p>\s*(?P<title>(<[ibu]>){0,2}(\s*\w+){1,4}\s*(</[ibu]>){0,2}\s*<p>)?'), chap_head),)
 
+        length = -1
         if getattr(self.extra_opts, 'unwrap_factor', 0.0) > 0.01:
             length = line_length('pdf', html, getattr(self.extra_opts, 'unwrap_factor'))
             if length:
@@ -425,7 +426,7 @@ class HTMLPreProcessor(object):
         for rule in rules + end_rules:
             html = rule[0].sub(rule[1], html)
 
-        if is_pdftohtml:
+        if is_pdftohtml and length > -1:
             # Dehyphenate
             dehyphenator = Dehyphenator()
             html = dehyphenator(html,'pdf', length)

src/calibre/gui2/dialogs/metadata_single.py

@@ -819,7 +819,8 @@ class MetadataSingleDialog(ResizableDialog, Ui_MetadataSingleDialog):
                 fname = err.filename if err.filename else 'file'
                 return error_dialog(self, _('Permission denied'),
                         _('Could not open %s. Is it being used by another'
-                        ' program?')%fname, show=True)
+                        ' program?')%fname, det_msg=traceback.format_exc(),
+                        show=True)
             raise
         self.save_state()
         QDialog.accept(self)

src/calibre/library/database2.py

@@ -870,7 +870,13 @@ class LibraryDatabase2(LibraryDatabase, SchemaUpgrade, CustomColumns):
         path = self.format_abspath(index, format, index_is_id=index_is_id)
         if path is not None:
             f = open(path, mode)
+            try:
                 ret = f if as_file else f.read()
+            except IOError:
+                f.seek(0)
+                out = cStringIO.StringIO()
+                shutil.copyfileobj(f, out)
+                ret = out.getvalue()
             if not as_file:
                 f.close()
             return ret

src/calibre/library/server/content.py

@@ -123,8 +123,6 @@ class ContentServer(object):
 
         return self.static('index.html')
 
-
-
     # Actually get content from the database {{{
     def get_cover(self, id, thumbnail=False):
         cover = self.db.cover(id, index_is_id=True, as_file=False)

src/calibre/library/server/mobile.py

@@ -19,6 +19,7 @@ from calibre.ebooks.metadata import fmt_sidx
 from calibre.constants import __appname__
 from calibre import human_readable
 from calibre.utils.date import utcfromtimestamp
+from calibre.utils.filenames import ascii_filename
 
 def CLASS(*args, **kwargs): # class is a reserved word in Python
     kwargs['class'] = ' '.join(args)
@@ -111,11 +112,13 @@ def build_index(books, num, search, sort, order, start, total, url_base, CKEYS):
         data = TD()
         last = None
         for fmt in book['formats'].split(','):
+            a = ascii_filename(book['authors'])
+            t = ascii_filename(book['title'])
             s = SPAN(
                 A(
                     fmt.lower(),
-                    href='/get/%s/%s-%s_%d.%s' % (fmt, book['authors'],
-                        book['title'], book['id'], fmt)
+                    href='/get/%s/%s-%s_%d.%s' % (fmt, a, t,
+                        book['id'], fmt)
                 ),
                 CLASS('button'))
             s.tail = u'\u202f' #  

src/calibre/library/server/xml.py

@@ -16,6 +16,7 @@ from calibre.library.server.utils import strftime, format_tag_string
 from calibre.ebooks.metadata import fmt_sidx
 from calibre.constants import preferred_encoding
 from calibre import isbytestring
+from calibre.utils.filenames import ascii_filename
 
 E = ElementMaker()
 
@@ -92,6 +93,8 @@ class XMLServer(object):
                     y = format_tag_string(y, ',', ignore_max=True)
                 kwargs[x] = serialize(y) if y else ''
 
+            kwargs['safe_title'] = ascii_filename(kwargs['title'])
+
             c = kwargs.pop('comments')
 
             CFM = self.db.field_metadata