From 9a9b94ef0b46039ab11e806bffffcb496141492a Mon Sep 17 00:00:00 2001 From: Charles Haley <> Date: Mon, 23 Aug 2010 12:28:16 +0100 Subject: [PATCH] Improve performance of 'remove all tags' in custom_column_widgets.py --- src/calibre/gui2/custom_column_widgets.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/calibre/gui2/custom_column_widgets.py b/src/calibre/gui2/custom_column_widgets.py index f364638f37..0e89358c53 100644 --- a/src/calibre/gui2/custom_column_widgets.py +++ b/src/calibre/gui2/custom_column_widgets.py @@ -550,9 +550,7 @@ class BulkText(BulkBase): remove_all, adding, rtext = self.gui_val remove = set() if remove_all: - for book_id in book_ids: - remove |= set(self.db.get_custom(book_id, num=self.col_id, - index_is_id=True)) + remove = set(self.db.all_custom(num=self.col_id)) else: txt = rtext if txt: