Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Release the GIL when calling getlongpathname as it does I/O

Browse Source
This commit is contained in:
Kovid Goyal 2020-10-30 21:57:45 +05:30
parent a13dd062f3
commit 9be75ea01d
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/calibre/utils/windows/winutil.cpp
View File

@ -773,13 +773,18 @@ get_long_path_name(PyObject *self, PyObject *args) {
DWORD current_size = 4096; DWORD current_size = 4096;
wchar_raii buf((wchar_t*)PyMem_Malloc(current_size * sizeof(wchar_t))); wchar_raii buf((wchar_t*)PyMem_Malloc(current_size * sizeof(wchar_t)));
if (!buf) return PyErr_NoMemory(); if (!buf) return PyErr_NoMemory();
DWORD needed_size = GetLongPathNameW(path.ptr(), buf.ptr(), current_size); DWORD needed_size;
Py_BEGIN_ALLOW_THREADS
needed_size = GetLongPathNameW(path.ptr(), buf.ptr(), current_size);
Py_END_ALLOW_THREADS
if (needed_size >= current_size - 32) { if (needed_size >= current_size - 32) {
current_size = needed_size + 32; current_size = needed_size + 32;
PyMem_Free(buf.ptr()); PyMem_Free(buf.ptr());
buf.set_ptr((wchar_t*)PyMem_Malloc(current_size * sizeof(wchar_t))); buf.set_ptr((wchar_t*)PyMem_Malloc(current_size * sizeof(wchar_t)));
if (!buf) return PyErr_NoMemory(); if (!buf) return PyErr_NoMemory();
Py_BEGIN_ALLOW_THREADS
needed_size = GetLongPathNameW(path.ptr(), buf.ptr(), current_size); needed_size = GetLongPathNameW(path.ptr(), buf.ptr(), current_size);
Py_END_ALLOW_THREADS
} }
if (!needed_size) return PyErr_SetExcFromWindowsErrWithFilenameObject(PyExc_OSError, 0, PyTuple_GET_ITEM(args, 0)); if (!needed_size) return PyErr_SetExcFromWindowsErrWithFilenameObject(PyExc_OSError, 0, PyTuple_GET_ITEM(args, 0));
if (needed_size >= current_size - 2) { if (needed_size >= current_size - 2) {