Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-11-03 19:17:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Edit Book: Check Book: Add a check for manifest items missing href attributes. Fixes #1339766 [Validator gives error on “href” attribute in manifest item for remote resources](https://bugs.launchpad.net/calibre/+bug/1339766)

Browse Source
This commit is contained in:
Kovid Goyal 2014-07-10 09:54:37 +05:30
parent 54f774c375
commit 9c8357c31b
1 changed files with 32 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/calibre/ebooks/oeb/polish/check/opf.py
View File

@ -62,6 +62,25 @@ class IncorrectToc(BaseError):
self.HELP = _('The media type for the table of contents must be %s') % guess_type('a.ncx')
BaseError.__init__(self, msg, name, lnum)
class NoHref(BaseError):
HELP = _('This manifest entry has no href attribute. Either add the href attribute or remove the entry.')
INDIVIDUAL_FIX = _('Remove this manifest entry')
def __init__(self, name, item_id, lnum):
BaseError.__init__(self, _('Item in manifest has no href attribute'), name, lnum)
self.item_id = item_id
def __call__(self, container):
changed = False
for item in container.opf_xpath('/opf:package/opf:manifest/opf:item'):
if item.get('id', None) == self.item_id:
changed = True
container.remove_from_xml(item)
container.dirty(container.opf_name)
return changed
class MissingHref(BaseError):
HELP = _('A file listed in the manifest is missing, you should either remove'
@ -213,17 +232,20 @@ def check_opf(container):
errors.append(NonLinearItems(container.opf_name, nl_items))
seen, dups = {}, {}
for item in container.opf_xpath('/opf:package/opf:manifest/opf:item[@href]'):
href = item.get('href')
hname = container.href_to_name(href, container.opf_name)
if not hname or not container.exists(hname):
errors.append(MissingHref(container.opf_name, href, item.sourceline))
if href in seen:
if href not in dups:
dups[href] = [seen[href]]
dups[href].append(item.sourceline)
for item in container.opf_xpath('/opf:package/opf:manifest/opf:item'):
href = item.get('href', None)
if href is None:
errors.append(NoHref(container.opf_name, item.get('id', None), item.sourceline))
else:
seen[href] = item.sourceline
hname = container.href_to_name(href, container.opf_name)
if not hname or not container.exists(hname):
errors.append(MissingHref(container.opf_name, href, item.sourceline))
if href in seen:
if href not in dups:
dups[href] = [seen[href]]
dups[href].append(item.sourceline)
else:
seen[href] = item.sourceline
errors.extend(DuplicateHref(container.opf_name, eid, locs) for eid, locs in dups.iteritems())
seen, dups = {}, {}