Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Performance improvement: don't run the device info sync code when adding or deleting a book. The code was already run when the device connected, and nothing critical could change between then and an add/delete.

Browse Source
This commit is contained in:
Charles Haley 2014-11-30 10:31:49 +01:00
parent 9229cdc402
commit 9c9925850e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/calibre/gui2/device.py
View File

@ -1183,7 +1183,8 @@ class DeviceMixin(object): # {{{
# set_books_in_library even though books were not added because # set_books_in_library even though books were not added because
# the deleted book might have been an exact match. Upload the booklists # the deleted book might have been an exact match. Upload the booklists
# if set_books_in_library did not. # if set_books_in_library did not.
if not self.set_books_in_library(self.booklists(), reset=True, add_as_step_to_job=job): if not self.set_books_in_library(self.booklists(), reset=True,
add_as_step_to_job=job, do_device_sync=False):
self.upload_booklists(job) self.upload_booklists(job)
# We need to reset the ondevice flags in the library. Use a big hammer, # We need to reset the ondevice flags in the library. Use a big hammer,
# so we don't need to worry about whether some succeeded or not. # so we don't need to worry about whether some succeeded or not.
@ -1634,7 +1635,8 @@ class DeviceMixin(object): # {{{
# because the UUID changed. Force both the device and the library view # because the UUID changed. Force both the device and the library view
# to refresh the flags. Set_books_in_library could upload the booklists. # to refresh the flags. Set_books_in_library could upload the booklists.
# If it does not, then do it here. # If it does not, then do it here.
if not self.set_books_in_library(self.booklists(), reset=True, add_as_step_to_job=job): if not self.set_books_in_library(self.booklists(), reset=True,
add_as_step_to_job=job, do_device_sync=False):
self.upload_booklists(job) self.upload_booklists(job)
self.refresh_ondevice() self.refresh_ondevice()
@ -1719,7 +1721,7 @@ class DeviceMixin(object): # {{{
book.thumbnail = self.default_thumbnail book.thumbnail = self.default_thumbnail
def set_books_in_library(self, booklists, reset=False, add_as_step_to_job=None, def set_books_in_library(self, booklists, reset=False, add_as_step_to_job=None,
force_send=False): force_send=False, do_device_sync=True):
''' '''
Set the ondevice indications in the device database. Set the ondevice indications in the device database.
This method should be called before book_on_device is called, because This method should be called before book_on_device is called, because
@ -1796,7 +1798,7 @@ class DeviceMixin(object): # {{{
if not update_metadata: if not update_metadata:
return False return False
if self.device_manager.device is not None: if do_device_sync and self.device_manager.device is not None:
set_of_ids, (fmt_name, date_bad) = \ set_of_ids, (fmt_name, date_bad) = \
self.device_manager.device.synchronize_with_db(db, id_, book, self.device_manager.device.synchronize_with_db(db, id_, book,
first_call_to_synchronize_with_db[0]) first_call_to_synchronize_with_db[0])