Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

When picking a random book ensure recently chosen books are not re-selected. Fixes #1948889 ["Pick a random book" function not random](https://bugs.launchpad.net/calibre/+bug/1948889)

Browse Source
This commit is contained in:
Kovid Goyal 2021-11-08 20:22:19 +05:30
parent 2f6ad90635
commit 9e1e87371f
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/calibre/gui2/actions/random.py
View File

@ -20,15 +20,29 @@ class PickRandomAction(InterfaceAction):
def genesis(self): def genesis(self):
self.qaction.triggered.connect(self.pick_random) self.qaction.triggered.connect(self.pick_random)
self.recently_picked = {}
def location_selected(self, loc): def location_selected(self, loc):
enabled = loc == 'library' enabled = loc == 'library'
self.qaction.setEnabled(enabled) self.qaction.setEnabled(enabled)
self.menuless_qaction.setEnabled(enabled) self.menuless_qaction.setEnabled(enabled)
def library_changed(self, db):
self.recently_picked = {}
def pick_random(self): def pick_random(self):
pick = random.randint(0, self.gui.library_view.model().rowCount(None)) lv = self.gui.library_view
self.gui.library_view.set_current_row(pick) count = lv.model().rowCount(None)
self.gui.library_view.scroll_to_row(pick) rp = self.recently_picked
while len(rp) > count // 2:
n = next(iter(rp))
del rp[n]
while True:
pick = random.randint(0, count)
if pick in rp:
continue
rp.pop(pick, None)
rp[pick] = True
break
lv.set_current_row(pick)
lv.scroll_to_row(pick)