From a551136f5bd62f12dc9379ad6b5fadb0538d7190 Mon Sep 17 00:00:00 2001
From: Kovid Goyal <kovid@kovidgoyal.net>
Date: Sat, 5 Jul 2014 21:26:21 +0530
Subject: [PATCH] MSI installer: Always re-install all files

---
 setup/installer/windows/wix-template.xml | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/setup/installer/windows/wix-template.xml b/setup/installer/windows/wix-template.xml
index 672a0b2507..600e2d226e 100644
--- a/setup/installer/windows/wix-template.xml
+++ b/setup/installer/windows/wix-template.xml
@@ -11,10 +11,17 @@
                         SummaryCodepage='1252' />
 
                 <Media Id="1" Cabinet="{app}.cab" CompressionLevel="{compression}" EmbedCab="yes" />
-                <!-- The following line ensures that DLLs are replaced even if their version is the same as before. This
-                     is necessary because of the manifest nuking that was part of making calibre isolated. But I think it
-                     is more rigorous anyway. -->
-                <Property Id='REINSTALLMODE' Value='emus'/>
+                <!-- The following line ensures that DLLs are replaced even if
+                     their version is the same as before or they dont have
+                     versions. Microsoft's brain dead installer will otherwise
+                     use file dates to determine whether to install a file or
+                     not. Simply not robust. And since we dont install any
+                     system files whatsoever, we can never replace a system
+                     file with an older version. This way the calibre install
+                     should always result in a consistent set of files being
+                     present in the installation folder, though of course, with
+                     Microsoft there are no guarantees of anything. -->
+                <Property Id='REINSTALLMODE' Value='amus'/>
 
                 <Upgrade Id="{upgrade_code}">
                     <UpgradeVersion Maximum="{version}"