From a69ff6e8dc21788ac2d1622e3a92c9abecd84424 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Sun, 27 Sep 2020 06:46:48 +0530 Subject: [PATCH] macOS: Fix right click menu in ToC editor not working Yet another place where Qt 5.15 breaks a menu without a parent on macOS. Fixes #1897409 [Can't 'remove all selected' table of contents items](https://bugs.launchpad.net/calibre/+bug/1897409) --- src/calibre/gui2/toc/main.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/calibre/gui2/toc/main.py b/src/calibre/gui2/toc/main.py index b2c0e37ff9..50219f7aa2 100644 --- a/src/calibre/gui2/toc/main.py +++ b/src/calibre/gui2/toc/main.py @@ -665,7 +665,7 @@ class TreeWidget(QTreeWidget): # {{{ return ' [%s]'%sc if item is not None: - m = QMenu() + m = QMenu(self) m.addAction(QIcon(I('edit_input.png')), _('Change the location this entry points to'), self.edit_item) m.addAction(QIcon(I('modified.png')), _('Bulk rename all selected items'), self.bulk_rename) m.addAction(QIcon(I('trash.png')), _('Remove all selected items'), self.del_items) @@ -683,7 +683,7 @@ class TreeWidget(QTreeWidget): # {{{ m.addAction(QIcon(I('forward.png')), (_('Indent "%s"')%ci)+key(Qt.Key_Right), self.move_right) m.addSeparator() - case_menu = QMenu(_('Change case')) + case_menu = QMenu(_('Change case'), m) case_menu.addAction(_('Upper case'), self.upper_case) case_menu.addAction(_('Lower case'), self.lower_case) case_menu.addAction(_('Swap case'), self.swap_case)