Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

No need to subclass

Browse Source
This commit is contained in:
Kovid Goyal 2020-01-01 14:10:57 +05:30
parent fbfebda03f
commit ad4d1f882a
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/calibre/utils/xml_parse.py
View File

@ -4,31 +4,28 @@
from __future__ import absolute_import, division, print_function, unicode_literals
from lxml import etree
import threading
# resolve_entities is turned off as entities can cause
# reads of local files, for example:
# <!DOCTYPE foo [ <!ENTITY passwd SYSTEM "file:///etc/passwd" >]>
class GlobalParserTLS(threading.local):
def __call__(self, recover):
parsers = getattr(self, 'parsers', None)
if parsers is None:
self.parsers = parsers = {
True: etree.XMLParser(recover=True, no_network=True, resolve_entities=False),
False: etree.XMLParser(recover=False, no_network=True, resolve_entities=False)
}
return parsers[recover]
_global_tls = GlobalParserTLS()
_global_tls = threading.local()
fs = etree.fromstring
def parser(recover):
parsers = getattr(_global_tls, 'parsers', None)
if parsers is None:
_global_tls.parsers = parsers = {
True:
etree.XMLParser(recover=True, no_network=True, resolve_entities=False),
False:
etree.XMLParser(recover=False, no_network=True, resolve_entities=False)
}
return parsers[recover]
def safe_xml_fromstring(string_or_bytes, recover=True):
return fs(string_or_bytes, _global_tls(recover))
return fs(string_or_bytes, parser(recover))