From b14ab0351b1ba87a3e9a8f6c7c52882caeeab03c Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Thu, 10 Dec 2020 12:11:36 +0530 Subject: [PATCH] PDF Output: Fix conversion failing when adding header/footer and the input document defines margins/padding on the tag. Fixes #1905736 [PDF conversion fails - number of header/footer pages](https://bugs.launchpad.net/calibre/+bug/1905736) --- src/calibre/ebooks/pdf/html_writer.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/calibre/ebooks/pdf/html_writer.py b/src/calibre/ebooks/pdf/html_writer.py index a44acdc2a7..610edffda6 100644 --- a/src/calibre/ebooks/pdf/html_writer.py +++ b/src/calibre/ebooks/pdf/html_writer.py @@ -1031,6 +1031,7 @@ def add_header_footer(manager, opts, pdf_doc, container, page_number_display_map report_progress(0.8, _('Adding headers and footers')) name = create_skeleton(container) root = container.parsed(name) + root.set('style', 'margin: 0; padding: 0; border-width: 0; background-color: unset;') body = last_tag(root) body.attrib.pop('id', None) body.set('style', 'margin: 0; padding: 0; border-width: 0; background-color: unset;') @@ -1181,6 +1182,7 @@ def add_header_footer(manager, opts, pdf_doc, container, page_number_display_map data = results[name] if not isinstance(data, bytes): raise SystemExit(data) + # open('/t/impose.pdf', 'wb').write(data) doc = data_as_pdf_doc(data) first_page_num = pdf_doc.page_count() num_pages = doc.page_count()