Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-31 14:33:54 -04:00
Code Issues Packages Projects Releases Wiki Activity

Edit Book: Add a check for links that do not point to HTML documents

Browse Source
This commit is contained in:
Kovid Goyal 2014-02-13 13:57:57 +05:30
parent b84fef0fb9
commit b469439270
2 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/calibre/ebooks/oeb/polish/check/links.py
View File

@ -49,6 +49,20 @@ class CaseMismatch(BadLink):
container.replace_links(self.name, replacer)
return replacer.replaced
class BadDestinationType(BaseError):
level = WARN
def __init__(self, link_source, link_dest, link_elem):
BaseError.__init__(self, _('Link points to a file that is not a text document'), link_source, line=link_elem.sourceline)
self.HELP = _('The link "{0}" points to a file <i>{1}</i> that is not a text (HTML) document.'
' Many ebook readers will be unable to follow such a link. You should'
' either remove the link or change it to point to a text document.'
' For example, if it points to an image, you can create small wrapper'
' document that contains the image and change the link to point to that.').format(
link_elem.get('href'), link_dest)
self.bad_href = link_elem.get('href')
class FileLink(BadLink):
HELP = _('This link uses the file:// URL scheme. This does not work with many ebook readers.'
@ -136,6 +150,16 @@ def check_mimetypes(container):
a(MimetypeMismatch(container, name, mt, gt))
return errors
def check_link_destinations(container):
errors = []
for name, mt in container.mime_map.iteritems():
if mt in OEB_DOCS:
for a in container.parsed(name).xpath('//*[local-name()="a" and @href]'):
tname = container.href_to_name(a.get('href'), name)
if tname and tname in container.mime_map and container.mime_map[tname] not in OEB_DOCS:
errors.append(BadDestinationType(name, tname, a))
return errors
def check_links(container):
links_map = defaultdict(set)
xml_types = {guess_type('a.opf'), guess_type('a.ncx')}

4
src/calibre/ebooks/oeb/polish/check/main.py
View File

@ -15,7 +15,7 @@ from calibre.ebooks.oeb.polish.check.base import run_checkers
from calibre.ebooks.oeb.polish.check.parsing import (
check_filenames, check_xml_parsing, check_css_parsing, fix_style_tag, check_html_size, check_ids)
from calibre.ebooks.oeb.polish.check.images import check_raster_images
from calibre.ebooks.oeb.polish.check.links import check_links, check_mimetypes
from calibre.ebooks.oeb.polish.check.links import check_links, check_mimetypes, check_link_destinations
from calibre.ebooks.oeb.polish.check.fonts import check_fonts
from calibre.ebooks.oeb.polish.check.opf import check_opf
@ -58,7 +58,7 @@ def run_checks(container):
errors.extend(check_css_parsing(name, raw, line_offset=elem.sourceline - 1, is_declaration=True))
errors += check_mimetypes(container)
errors += check_links(container)
errors += check_links(container) + check_link_destinations(container)
errors += check_fonts(container)
errors += check_filenames(container)
errors += check_ids(container)