diff --git a/src/calibre/gui2/ui.py b/src/calibre/gui2/ui.py index 0732ff4650..a6eeabd57f 100644 --- a/src/calibre/gui2/ui.py +++ b/src/calibre/gui2/ui.py @@ -19,7 +19,7 @@ from PyQt4.Qt import Qt, SIGNAL, QTimer, \ QMessageBox, QHelpEvent from calibre import prints -from calibre.constants import __appname__, isosx, DEBUG +from calibre.constants import __appname__, isosx from calibre.ptempfile import PersistentTemporaryFile from calibre.utils.config import prefs, dynamic from calibre.utils.ipc.server import Server @@ -590,9 +590,6 @@ class Main(MainWindow, MainWindowMixin, DeviceMixin, EmailMixin, # {{{ # Goes here, because if cf is valid, db is valid. db.prefs['field_metadata'] = db.field_metadata.all_metadata() db.commit_dirty_cache() - if DEBUG and db.gm_count > 0: - print 'get_metadata cache: {0:d} calls, {1:4.2f}% misses'.format( - db.gm_count, (db.gm_missed*100.0)/db.gm_count) for action in self.iactions.values(): if not action.shutting_down(): return diff --git a/src/calibre/library/caches.py b/src/calibre/library/caches.py index 0763318912..6aef45dbbd 100644 --- a/src/calibre/library/caches.py +++ b/src/calibre/library/caches.py @@ -598,7 +598,6 @@ class ResultCache(SearchQueryParser): # {{{ def set(self, row, col, val, row_is_id=False): id = row if row_is_id else self._map_filtered[row] - self._data[id][self.FIELD_MAP['all_metadata']] = None self._data[id][col] = val def get(self, row, col, row_is_id=False): @@ -629,7 +628,6 @@ class ResultCache(SearchQueryParser): # {{{ self._data[id] = CacheRow(db, self.composites, db.conn.get('SELECT * from meta2 WHERE id=?', (id,))[0]) self._data[id].append(db.book_on_device_string(id)) - self._data[id].append(None) except IndexError: return None try: @@ -646,7 +644,6 @@ class ResultCache(SearchQueryParser): # {{{ self._data[id] = CacheRow(db, self.composites, db.conn.get('SELECT * from meta2 WHERE id=?', (id,))[0]) self._data[id].append(db.book_on_device_string(id)) - self._data[id].append(None) self._map[0:0] = ids self._map_filtered[0:0] = ids @@ -671,7 +668,6 @@ class ResultCache(SearchQueryParser): # {{{ for item in self._data: if item is not None: item.append(db.book_on_device_string(item[0])) - item.append(None) self._map = [i[0] for i in self._data if i is not None] if field is not None: self.sort(field, ascending) diff --git a/src/calibre/library/database2.py b/src/calibre/library/database2.py index 138560020e..3b06064226 100644 --- a/src/calibre/library/database2.py +++ b/src/calibre/library/database2.py @@ -298,10 +298,8 @@ class LibraryDatabase2(LibraryDatabase, SchemaUpgrade, CustomColumns): base, prefer_custom=True) - self.FIELD_MAP['ondevice'] = base+1 - self.field_metadata.set_field_record_index('ondevice', base+1, prefer_custom=False) - self.FIELD_MAP['all_metadata'] = base+2 - self.field_metadata.set_field_record_index('all_metadata', base+2, prefer_custom=False) + self.FIELD_MAP['ondevice'] = base = base+1 + self.field_metadata.set_field_record_index('ondevice', base, prefer_custom=False) script = ''' DROP VIEW IF EXISTS meta2; @@ -690,19 +688,7 @@ class LibraryDatabase2(LibraryDatabase, SchemaUpgrade, CustomColumns): ''' row = self.data._data[idx] if index_is_id else self.data[idx] fm = self.FIELD_MAP - - self.gm_count += 1 - mi = row[self.FIELD_MAP['all_metadata']] - if mi is not None: - if get_cover: - # Always get the cover, because the value can be wrong if the - # original mi was from the OPF - mi.cover = self.cover(idx, index_is_id=index_is_id, as_path=True) - return mi - - self.gm_missed += 1 mi = Metadata(None) - self.data.set(idx, fm['all_metadata'], mi, row_is_id = index_is_id) aut_list = row[fm['au_map']] aut_list = [p.split(':::') for p in aut_list.split(':#:')] diff --git a/src/calibre/library/field_metadata.py b/src/calibre/library/field_metadata.py index 676eb13d2b..2a9b7e7003 100644 --- a/src/calibre/library/field_metadata.py +++ b/src/calibre/library/field_metadata.py @@ -162,15 +162,6 @@ class FieldMetadata(dict): 'search_terms':['tags', 'tag'], 'is_custom':False, 'is_category':True}), - ('all_metadata',{'table':None, - 'column':None, - 'datatype':None, - 'is_multiple':None, - 'kind':'field', - 'name':None, - 'search_terms':[], - 'is_custom':False, - 'is_category':False}), ('author_sort',{'table':None, 'column':None, 'datatype':'text',