Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-06-23 15:30:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

Simplify db retrieval when creating editor

Browse Source
This commit is contained in:
Kovid Goyal 2025-02-10 09:41:19 +05:30
parent 5da6c49d8f
commit c02b3182ee
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/calibre/gui2/library/delegates.py
View File

@ -397,18 +397,15 @@ class CompleteDelegate(StyledItemDelegate, UpdateEditorGeometry, EditableTextDel
self.items_func_name = items_func_name self.items_func_name = items_func_name
self.space_before_sep = space_before_sep self.space_before_sep = space_before_sep
@property
def db(self):
return self.parent().model().db
def create_editor(self, parent, option, index): def create_editor(self, parent, option, index):
if self.db and hasattr(self.db, self.items_func_name): db = index.model().db
if hasattr(db, self.items_func_name):
m = index.model() m = index.model()
col = m.column_map[index.column()] col = m.column_map[index.column()]
# If shifted, bring up the tag editor instead of the line editor. # If shifted, bring up the tag editor instead of the line editor.
if not self.ignore_kb_mods_on_edit and check_key_modifier(Qt.KeyboardModifier.ShiftModifier) and col != 'authors': if not self.ignore_kb_mods_on_edit and check_key_modifier(Qt.KeyboardModifier.ShiftModifier) and col != 'authors':
key = col if m.is_custom_column(col) else None key = col if m.is_custom_column(col) else None
d = TagEditor(parent, self.db, m.id(index.row()), key=key) d = TagEditor(parent, db, m.id(index.row()), key=key)
if d.exec() == QDialog.DialogCode.Accepted: if d.exec() == QDialog.DialogCode.Accepted:
m.setData(index, self.sep.join(d.tags), Qt.ItemDataRole.EditRole) m.setData(index, self.sep.join(d.tags), Qt.ItemDataRole.EditRole)
return None return None
@ -421,10 +418,10 @@ class CompleteDelegate(StyledItemDelegate, UpdateEditorGeometry, EditableTextDel
if self.sep == '&': if self.sep == '&':
editor.set_add_separator(tweaks['authors_completer_append_separator']) editor.set_add_separator(tweaks['authors_completer_append_separator'])
if not m.is_custom_column(col): if not m.is_custom_column(col):
all_items = getattr(self.db, self.items_func_name)() all_items = getattr(db, self.items_func_name)()
else: else:
all_items = list(self.db.all_custom( all_items = list(db.all_custom(
label=self.db.field_metadata.key_to_label(col))) label=db.field_metadata.key_to_label(col)))
editor.update_items_cache(all_items) editor.update_items_cache(all_items)
else: else:
editor = EnLineEdit(parent) editor = EnLineEdit(parent)