From c071bb5be197e7506b298fb7b91ac2d442d74275 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Fri, 25 Dec 2020 18:30:06 +0530 Subject: [PATCH] Fix dropping files onto book details causing an error if the confirmation dialog is disabled. Fixes #1909291 [Cannot add additional formats via drag-and-drop in 5.8.1](https://bugs.launchpad.net/calibre/+bug/1909291) --- src/calibre/gui2/dialogs/confirm_delete.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/calibre/gui2/dialogs/confirm_delete.py b/src/calibre/gui2/dialogs/confirm_delete.py index 8ebc2b0b7b..5e26c12cac 100644 --- a/src/calibre/gui2/dialogs/confirm_delete.py +++ b/src/calibre/gui2/dialogs/confirm_delete.py @@ -73,6 +73,8 @@ def confirm(msg, name, parent=None, pixmap='dialog_warning.png', title=None, show_cancel_button=True, confirm_msg=None, config_set=None, extra_button=None): config_set = config_set or dynamic if not config_set.get(confirm_config_name(name), True): + if extra_button: + return True, False return True d = Dialog(msg, name, parent, config_set=config_set, icon=pixmap, extra_button=extra_button, title=title, confirm_msg=confirm_msg, show_cancel_button=show_cancel_button)