From c9f8ffedb17669d713bdfe3a29b209f50443454e Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Wed, 28 Aug 2019 11:53:07 -0400 Subject: [PATCH] micro-optimization: sorted() can take any iterable and returns a list So there is no need to convert everything to lists before and after. Also, all_formats is immediately converted to a set, and kept that way, so it does not need to always be accessed as set(all_formats). --- src/calibre/gui2/device_drivers/configwidget.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/calibre/gui2/device_drivers/configwidget.py b/src/calibre/gui2/device_drivers/configwidget.py index a6be604f38..bcc712d48c 100644 --- a/src/calibre/gui2/device_drivers/configwidget.py +++ b/src/calibre/gui2/device_drivers/configwidget.py @@ -35,11 +35,11 @@ class ConfigWidget(QWidget, Ui_ConfigWidget): except TypeError: self.device_name = getattr(device, 'gui_name', None) or _('Device') if device.USER_CAN_ADD_NEW_FORMATS: - all_formats = set(all_formats) | set(BOOK_EXTENSIONS) + all_formats = all_formats | set(BOOK_EXTENSIONS) format_map = settings.format_map - disabled_formats = list(set(all_formats).difference(format_map)) - for format in format_map + list(sorted(disabled_formats)): + disabled_formats = all_formats.difference(format_map) + for format in format_map + sorted(disabled_formats): item = QListWidgetItem(format, self.columns) item.setData(Qt.UserRole, (format)) item.setFlags(Qt.ItemIsEnabled|Qt.ItemIsUserCheckable|Qt.ItemIsSelectable)