From d1589e00f3d5c46eb2304b4b234366407ada151c Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Thu, 8 Aug 2024 12:46:06 +0530 Subject: [PATCH] Email delivery: When sending emails to Kindle's dont convert filenames to English letters as Amazon appears to have finally fixed their email servers to handle non-English filenames. Fixes #2378 (use ebook title (name) as the email attachment name) --- src/calibre/gui2/email.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/calibre/gui2/email.py b/src/calibre/gui2/email.py index 894c69087b..4d05f8c170 100644 --- a/src/calibre/gui2/email.py +++ b/src/calibre/gui2/email.py @@ -167,11 +167,10 @@ def send_mails(jobnames, callback, attachments, to_s, subjects, # irony that they are called "tech" companies. # https://bugs.launchpad.net/calibre/+bug/1989282 from calibre.utils.short_uuid import uuid4 - if is_for_kindle(to): + if not is_for_kindle(to): + # Amazon nowadays reads metadata from attachment filename instead of + # file internal metadata so dont nuke the filename. # https://www.mobileread.com/forums/showthread.php?t=349290 - from calibre.utils.filenames import ascii_filename - aname = ascii_filename(aname) - else: aname = f'{uuid4()}.' + aname.rpartition('.')[-1] subject = uuid4() text = uuid4()