Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Disallow empty cite templates

Browse Source
This commit is contained in:
Kovid Goyal 2024-04-10 10:46:41 +05:30
parent 0448994661
commit d67ee294c7
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/pyj/read_book/prefs/selection.pyj
View File

@ -34,8 +34,9 @@ def set_actions(use_defaults):
def restore_defaults(): def restore_defaults():
container = get_container() container = get_container()
sd = session_defaults()
for control in container.querySelectorAll('input[name]'): for control in container.querySelectorAll('input[name]'):
val = session_defaults()[control.getAttribute('name')] val = sd[control.getAttribute('name')]
if control.type is 'checkbox': if control.type is 'checkbox':
control.checked = val control.checked = val
elif control.type is 'number': elif control.type is 'number':
@ -44,7 +45,7 @@ def restore_defaults():
control.value = val control.value = val
for ta in container.querySelectorAll('textarea[name]'): for ta in container.querySelectorAll('textarea[name]'):
val = session_defaults()[ta.getAttribute('name')] val = sd[ta.getAttribute('name')]
ta.value = val ta.value = val
set_actions(True) set_actions(True)
@ -174,7 +175,7 @@ def create_selection_panel(container, apply_func, cancel_func):
def cite_template_textarea(name, text, title): def cite_template_textarea(name, text, title):
ans = E.textarea(name=name, style='width: 100%; margin-top: 1ex; box-sizing: border-box; flex-grow: 10') ans = E.textarea(name=name, style='width: 100%; margin-top: 1ex; box-sizing: border-box; flex-grow: 10')
ans.value = sd.get(name) or '[{text}]({url})' ans.value = sd.get(name)
return E.div(style='margin-top:1ex', E.label(text, E.br(), ans)) return E.div(style='margin-top:1ex', E.label(text, E.br(), ans))
container.appendChild(cb( container.appendChild(cb(
@ -254,7 +255,7 @@ def commit_selection(onchange):
# Save textarea # Save textarea
for ta in container.querySelectorAll('textarea[name]'): for ta in container.querySelectorAll('textarea[name]'):
name = ta.getAttribute('name') name = ta.getAttribute('name')
val = ta.value or '' val = (ta.value or '').strip() or session_defaults()[name]
old = sd.get(name) old = sd.get(name)
if old is not val: if old is not val:
sd.set(name, val) sd.set(name, val)