Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-06-23 15:30:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

Reduce the amount of work for initializing completion in the edit metadata dialog

Browse Source
This commit is contained in:
Kovid Goyal 2020-10-13 13:48:30 +05:30
parent 0e37c78ed9
commit d707bdf3c9
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 6 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/calibre/gui2/metadata/basic_widgets.py
View File

@ -388,7 +388,7 @@ class AuthorsEdit(EditWithComplete, ToMetadataMixin):
self.set_separator('&') self.set_separator('&')
self.set_space_before_sep(True) self.set_space_before_sep(True)
self.set_add_separator(tweaks['authors_completer_append_separator']) self.set_add_separator(tweaks['authors_completer_append_separator'])
self.update_items_cache(db.all_author_names()) self.update_items_cache(db.new_api.all_field_names('authors'))
au = db.authors(id_, index_is_id=True) au = db.authors(id_, index_is_id=True)
if not au: if not au:
@ -612,17 +612,9 @@ class SeriesEdit(EditWithComplete, ToMetadataMixin):
def initialize(self, db, id_): def initialize(self, db, id_):
self.books_to_refresh = set() self.books_to_refresh = set()
all_series = db.all_series() self.update_items_cache(db.new_api.all_field_names('series'))
all_series.sort(key=lambda x: sort_key(x[1])) series = db.new_api.field_for('series', id_)
self.update_items_cache([x[1] for x in all_series]) self.current_val = self.original_val = series or ''
series_id = db.series_id(id_, index_is_id=True)
inval = ''
for i in all_series:
if i[0] == series_id:
inval = i[1]
break
self.current_val = inval
self.original_val = self.current_val
def commit(self, db, id_): def commit(self, db, id_):
series = self.current_val series = self.current_val
@ -1775,16 +1767,8 @@ class PublisherEdit(EditWithComplete, ToMetadataMixin): # {{{
def initialize(self, db, id_): def initialize(self, db, id_):
self.books_to_refresh = set() self.books_to_refresh = set()
all_publishers = db.all_publishers() self.update_items_cache(db.new_api.all_field_names('publisher'))
all_publishers.sort(key=lambda x: sort_key(x[1])) self.original_val = self.current_val = db.new_api.field_for('publisher', id_)
self.update_items_cache([x[1] for x in all_publishers])
publisher_id = db.publisher_id(id_, index_is_id=True)
inval = ''
for pid, name in all_publishers:
if pid == publisher_id:
inval = name
break
self.original_val = self.current_val = inval
def commit(self, db, id_): def commit(self, db, id_):
self.books_to_refresh |= db.set_publisher(id_, self.current_val, self.books_to_refresh |= db.set_publisher(id_, self.current_val,