From dac7563405e81522f6d3b3d06357aefe74cb3fbb Mon Sep 17 00:00:00 2001 From: Charles Haley Date: Sat, 1 Aug 2020 13:39:10 +0100 Subject: [PATCH] Fix bug #1889973 custom column of bool type: cannot delete default value once it's set --- src/calibre/gui2/preferences/create_custom_column.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/calibre/gui2/preferences/create_custom_column.py b/src/calibre/gui2/preferences/create_custom_column.py index ed5e7d9cc6..8c62aed5eb 100644 --- a/src/calibre/gui2/preferences/create_custom_column.py +++ b/src/calibre/gui2/preferences/create_custom_column.py @@ -543,6 +543,8 @@ class CreateCustomColumn(QDialog): default_val = (unicode_type(self.default_value.text()).strip() if col_type != 'composite' else None) + if self.editing_col: + self.parent.custcols[self.orig_column_name]['display'].pop('default_value', None) if col_type == 'datetime': if unicode_type(self.format_box.text()).strip():