From daef0914cd2e6456927faf75cbc8ef3cfab2d319 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Tue, 3 Dec 2024 08:23:26 +0530 Subject: [PATCH] Fix #2090888 [id_to_index failure during metadata edit](https://bugs.launchpad.net/calibre/+bug/2090888) --- src/calibre/db/view.py | 2 +- src/calibre/gui2/actions/edit_metadata.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/calibre/db/view.py b/src/calibre/db/view.py index 8f28c6a9b6..a97cf93e6e 100644 --- a/src/calibre/db/view.py +++ b/src/calibre/db/view.py @@ -232,7 +232,7 @@ class View: try: return self._real_map_filtered_id_to_row[book_id] except KeyError: - raise ValueError(f'No such book_id {book_id}') + raise ValueError(f'No such book_id {book_id} in current view') row = index_to_id def index(self, book_id, cache=False): diff --git a/src/calibre/gui2/actions/edit_metadata.py b/src/calibre/gui2/actions/edit_metadata.py index f61d2cdb16..762621678b 100644 --- a/src/calibre/gui2/actions/edit_metadata.py +++ b/src/calibre/gui2/actions/edit_metadata.py @@ -506,8 +506,7 @@ class EditMetadataAction(InterfaceActionWithLibraryDrop): if id_ is None: view._view_file(fmt) else: - db = self.gui.library_view.model().db - view.view_format(db.row(id_), fmt) + view.view_format_by_id(id_, fmt) def edit_format_callback(self, id_, fmt): edit = self.gui.iactions['Tweak ePub']