Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Workaround for bug in Qt causing a crash on unhandled exception in current_changed

Browse Source
This commit is contained in:
Kovid Goyal 2022-03-06 15:21:35 +05:30
parent 7e645a0e30
commit e467468783
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/calibre/gui2/library/models.py
View File

@ -578,11 +578,17 @@ class BooksModel(QAbstractTableModel): # {{{
def current_changed(self, current, previous, emit_signal=True): def current_changed(self, current, previous, emit_signal=True):
if current.isValid(): if current.isValid():
idx = current.row() idx = current.row()
data = self.get_book_display_info(idx) try:
if emit_signal: data = self.get_book_display_info(idx)
self.new_bookdisplay_data.emit(data) except Exception:
import traceback
error_dialog(None, _('Unhandled error'), _(
'Failed to read book data from calibre library. Click "Show details" for more information'), det_msg=traceback.format_exc(), show=True)
else: else:
return data if emit_signal:
self.new_bookdisplay_data.emit(data)
else:
return data
def get_book_info(self, index): def get_book_info(self, index):
if isinstance(index, numbers.Integral): if isinstance(index, numbers.Integral):
@ -1601,11 +1607,17 @@ class DeviceBooksModel(BooksModel): # {{{
def current_changed(self, current, previous, emit_signal=True): def current_changed(self, current, previous, emit_signal=True):
if current.isValid(): if current.isValid():
idx = current.row() idx = current.row()
data = self.get_book_display_info(idx) try:
if emit_signal: data = self.get_book_display_info(idx)
self.new_bookdisplay_data.emit(data) except Exception:
import traceback
error_dialog(None, _('Unhandled error'), _(
'Failed to read book data from calibre library. Click "Show details" for more information'), det_msg=traceback.format_exc(), show=True)
else: else:
return data if emit_signal:
self.new_bookdisplay_data.emit(data)
else:
return data
def paths(self, rows): def paths(self, rows):
return [self.db[self.map[r.row()]].path for r in rows] return [self.db[self.map[r.row()]].path for r in rows]