From 2787b65310e60c3b92d52ae43fed0598b2426965 Mon Sep 17 00:00:00 2001 From: Charles Haley Date: Wed, 12 Feb 2025 20:40:40 +0000 Subject: [PATCH 1/2] Add a note to the L&F / Book Details custom author url tooltip that the author is already URL-encoded. --- src/calibre/gui2/preferences/look_feel_tabs/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/calibre/gui2/preferences/look_feel_tabs/__init__.py b/src/calibre/gui2/preferences/look_feel_tabs/__init__.py index eb8d6ce06c..d07753e618 100644 --- a/src/calibre/gui2/preferences/look_feel_tabs/__init__.py +++ b/src/calibre/gui2/preferences/look_feel_tabs/__init__.py @@ -66,7 +66,8 @@ class DefaultAuthorLink(QWidget): u.setToolTip(_( 'Enter the URL to search. It should contain the string {0}' '\nwhich will be replaced by the author name. For example,' - '\n{1}').format('{author}', 'https://en.wikipedia.org/w/index.php?search={author}')) + '\n{1}. Note: the author name is already URL-encoded.').format( + '{author}', 'https://en.wikipedia.org/w/index.php?search={author}')) u.textChanged.connect(self.changed_signal) u.setPlaceholderText(_('Enter the URL')) ul.addWidget(u) From f92971b513dc1494948a807d57327011d9d31bb5 Mon Sep 17 00:00:00 2001 From: Charles Haley Date: Wed, 12 Feb 2025 21:47:57 +0000 Subject: [PATCH 2/2] Bug #2098133: Setting custom icon for category doesn't work --- src/calibre/gui2/tag_browser/view.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/calibre/gui2/tag_browser/view.py b/src/calibre/gui2/tag_browser/view.py index 4f5bb653e4..332a9cc924 100644 --- a/src/calibre/gui2/tag_browser/view.py +++ b/src/calibre/gui2/tag_browser/view.py @@ -713,7 +713,8 @@ class TagsView(QTreeView): # {{{ self.recount() return icon_file_name, for_children = extra if extra is not None else (None, None) - item_val, desired_file_name = make_icon_name(key, index, self._model.get_node(index).tag.id) + item_val, desired_file_name = make_icon_name(key, index, + None if index is None else self._model.get_node(index).tag.id) if icon_file_name is None: # User wants to specify a specific icon try: