Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-06-23 15:30:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

Proper fix for random crashes

Browse Source
This commit is contained in:
Kovid Goyal 2018-12-15 13:16:53 +05:30
parent 46c646e49d
commit e4e313f1d6
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/calibre/gui2/viewer2/web_view.py
View File

@ -127,6 +127,8 @@ class UrlSchemeHandler(QWebEngineUrlSchemeHandler):
def send_reply(self, rq, mime_type, data): def send_reply(self, rq, mime_type, data):
if sip.isdeleted(rq): if sip.isdeleted(rq):
return return
# make the buf a child of rq so that it is automatically deleted when
# rq is deleted
buf = QBuffer(parent=rq) buf = QBuffer(parent=rq)
buf.open(QBuffer.WriteOnly) buf.open(QBuffer.WriteOnly)
# we have to copy data into buf as it will be garbage # we have to copy data into buf as it will be garbage
@ -134,9 +136,7 @@ class UrlSchemeHandler(QWebEngineUrlSchemeHandler):
buf.write(data) buf.write(data)
buf.seek(0) buf.seek(0)
buf.close() buf.close()
buf.aboutToClose.connect(buf.deleteLater)
rq.reply(mime_type.encode('ascii'), buf) rq.reply(mime_type.encode('ascii'), buf)
# }}} # }}}