From e4f2cdf94704940614873c53b10430c64cd980e4 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Mon, 4 Nov 2019 20:02:44 +0530 Subject: [PATCH] Book details panel: Fix removal of identifiers via right click not working --- src/calibre/ebooks/metadata/book/render.py | 2 +- src/calibre/gui2/book_details.py | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/calibre/ebooks/metadata/book/render.py b/src/calibre/ebooks/metadata/book/render.py index f8cea2cf91..e25a57688e 100644 --- a/src/calibre/ebooks/metadata/book/render.py +++ b/src/calibre/ebooks/metadata/book/render.py @@ -200,7 +200,7 @@ def mi_to_html(mi, field_list=None, default_author_link=None, use_roman_numbers= urls = urls_from_identifiers(mi.identifiers) links = [ '%s' % ( - action('identifier', url=url, name=namel, type=id_typ, value=id_val, field='identifiers', book_id=book_id), + action('identifier', url=url, name=namel, id_type=id_typ, value=id_val, field='identifiers', book_id=book_id), a(id_typ), a(id_val), p(namel)) for namel, id_typ, id_val, url in urls] links = u', '.join(links) diff --git a/src/calibre/gui2/book_details.py b/src/calibre/gui2/book_details.py index c68ba19cc8..d2b09e264c 100644 --- a/src/calibre/gui2/book_details.py +++ b/src/calibre/gui2/book_details.py @@ -251,13 +251,14 @@ def add_item_specific_entries(menu, data, book_info): field = data.get('field') if field is not None: book_id = int(data['book_id']) - value = data['value'] + value = remove_value = data['value'] if field == 'identifiers': menu.addAction(book_info.edit_identifiers_action) + remove_value = data['id_type'] elif field in ('tags', 'series', 'publisher') or is_category(field): menu.addAction(init_manage_action(book_info.manage_action, field, value)) ac = book_info.remove_item_action - ac.data = (field, value, book_id) + ac.data = (field, remove_value, book_id) ac.setText(_('Remove %s from this book') % value) menu.addAction(ac) return search_internet_added