Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Viewer: Extend workaround for Chrome resize in column mode after layout complete bug for all scrolling, not just end scrolling since it seems to affect all scrolling. Fixes #1894093 [Viewer not opening to exact spot it was closed at](https://bugs.launchpad.net/calibre/+bug/1894093)

Browse Source
This commit is contained in:
Kovid Goyal 2020-09-03 22:50:24 +05:30
parent df00db28f6
commit e759eefc28
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pyj/read_book/paged_mode.pyj
View File

@ -195,10 +195,11 @@ class ScrollResizeBugWatcher:
# In Chrome sometimes after layout the scrollWidth of body increases after a # In Chrome sometimes after layout the scrollWidth of body increases after a
# few milliseconds, this can cause scrolling to the end to not work # few milliseconds, this can cause scrolling to the end to not work
# immediately after layout # immediately after layout. This happens without a resize event, and
# without triggering the ResizeObserver and only in paged mode.
def __init__(self): def __init__(self):
self.max_time = 500 self.max_time = 750
self.last_layout_at = 0 self.last_layout_at = 0
self.last_command = None self.last_command = None
self.doc_size = 0 self.doc_size = 0
@ -212,7 +213,7 @@ class ScrollResizeBugWatcher:
def scrolled(self, pos, limit): def scrolled(self, pos, limit):
self.cancel_timer() self.cancel_timer()
now = window.performance.now() now = window.performance.now()
if pos >= limit - 2 * col_and_gap and now - self.last_layout_at < self.max_time and self.last_command is not None: if now - self.last_layout_at < self.max_time and self.last_command is not None:
self.doc_size = scroll_viewport.paged_content_inline_size() self.doc_size = scroll_viewport.paged_content_inline_size()
self.check_for_resize_bug() self.check_for_resize_bug()
@ -241,7 +242,6 @@ class ScrollResizeBugWatcher:
scroll_resize_bug_watcher = ScrollResizeBugWatcher() scroll_resize_bug_watcher = ScrollResizeBugWatcher()
def layout(is_single_page, on_resize): def layout(is_single_page, on_resize):
nonlocal _in_paged_mode, col_size, col_and_gap, screen_block, gap, screen_inline, is_full_screen_layout, cols_per_screen, number_of_cols nonlocal _in_paged_mode, col_size, col_and_gap, screen_block, gap, screen_inline, is_full_screen_layout, cols_per_screen, number_of_cols
line_height(True) line_height(True)