Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use atomic copying when installing icon theme

Browse Source 
Ensures no files are corrupted in case of power loss/crash
This commit is contained in:
Kovid Goyal 2015-08-26 10:06:05 +05:30
parent 78976ee9d7
commit e8fa0fc040
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/calibre/gui2/icon_theme.py
View File

@ -33,6 +33,7 @@ from calibre.utils.https import get_https_resource_securely, HTTPError
from calibre.utils.icu import numeric_sort_key as sort_key from calibre.utils.icu import numeric_sort_key as sort_key
from calibre.utils.magick import create_canvas, Image from calibre.utils.magick import create_canvas, Image
from calibre.utils.zipfile import ZipFile, ZIP_STORED from calibre.utils.zipfile import ZipFile, ZIP_STORED
from calibre.utils.filenames import atomic_rename
from lzma.xz import compress, decompress from lzma.xz import compress, decompress
IMAGE_EXTENSIONS = {'png', 'jpg', 'jpeg'} IMAGE_EXTENSIONS = {'png', 'jpg', 'jpeg'}
@ -684,6 +685,12 @@ def remove_icon_theme():
raise raise
os.remove(metadata_file) os.remove(metadata_file)
def safe_copy(src, destpath):
tpath = destpath + '-temp'
with open(tpath, 'wb') as dest:
shutil.copyfileobj(src, dest)
atomic_rename(tpath, destpath)
def install_icon_theme(theme, f): def install_icon_theme(theme, f):
icdir = os.path.abspath(os.path.join(config_dir, 'resources', 'images')) icdir = os.path.abspath(os.path.join(config_dir, 'resources', 'images'))
if not os.path.exists(icdir): if not os.path.exists(icdir):
@ -702,13 +709,15 @@ def install_icon_theme(theme, f):
destpath = os.path.abspath(os.path.join(base, os.path.basename(name))) destpath = os.path.abspath(os.path.join(base, os.path.basename(name)))
if not destpath.startswith(icdir): if not destpath.startswith(icdir):
continue continue
with zf.open(name) as src, open(destpath, 'wb') as dest: with zf.open(name) as src:
shutil.copyfileobj(src, dest) safe_copy(src, destpath)
theme['files'].add(name) theme['files'].add(name)
theme['files'] = tuple(theme['files']) theme['files'] = tuple(theme['files'])
with open(metadata_file, 'wb') as mf: buf = BytesIO()
json.dump(theme, mf, indent=2) json.dump(theme, buf, indent=2)
buf.seek(0)
safe_copy(buf, metadata_file)
if __name__ == '__main__': if __name__ == '__main__':
from calibre.gui2 import Application from calibre.gui2 import Application