Merge branch 'clean-unused-variable' of https://github.com/un-pogaz/calibre

This commit is contained in:
Kovid Goyal 2025-03-08 07:40:37 +05:30
commit ece7ad15b8
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
7 changed files with 3 additions and 12 deletions

View File

@ -26,8 +26,7 @@ ignore = [
'E402', 'E722', 'E741',
'UP012', 'UP030', 'UP038', 'C413', 'C420', 'PIE790', 'ISC003',
'RUF001', 'RUF002', 'RUF003', 'RUF005', 'RUF012', 'RUF013', 'RUF015', 'RUF031', 'RUF100',
'F841', # because in preview, unused tuple unpacking variable that not use dummy syntax (prefix '_' underscore)
# raise error 'unused-variable', sigh (https://github.com/astral-sh/ruff/issues/8884)
'RUF059', # unused unpacked variable
]
select = [
'E', 'F', 'I', 'W', 'INT',

View File

@ -190,7 +190,6 @@ class NewYorkTimes(BasicNewsRecipe):
script = type(u'')(script)
json_data = script[script.find('{'):script.rfind(';')].strip().rstrip(';')
data = json.loads(json_data.replace(':undefined', ':null'))['initialState']
containers, sections = {}, {}
article_map = {}
sections = []
for key in data:

View File

@ -190,7 +190,6 @@ class NewYorkTimes(BasicNewsRecipe):
script = type(u'')(script)
json_data = script[script.find('{'):script.rfind(';')].strip().rstrip(';')
data = json.loads(json_data.replace(':undefined', ':null'))['initialState']
containers, sections = {}, {}
article_map = {}
sections = []
for key in data:

View File

@ -2855,7 +2855,7 @@ class KOBOTOUCH(KOBO):
if self.isTolinoDevice() and self.dbversion >= 191:
ImageID_split = ImageID.rsplit('.', 1)
ImageID_split[0] = ImageID_split[0].replace('.', '_')
ImageId = '.'.join(ImageID_split)
ImageID = '.'.join(ImageID_split)
else:
ImageID = ImageID.replace('.', '_')
return ImageID

View File

@ -630,9 +630,8 @@ h1, h2, h3, h4, h5, h6, td {{
def profile():
from calibre.ptempfile import TemporaryDirectory
path = sys.argv[-1]
with TemporaryDirectory() as tdir, Profiler():
with Profiler():
kepubify_path(path, max_workers=1)

View File

@ -69,8 +69,6 @@ class Model(QStandardItemModel):
for cls in usbms_plugins():
for model in cls.model_metadata():
man_map.setdefault(model.manufacturer_name, []).append(model)
lcd = gprefs.get('last_connected_folder_as_device', None)
selected_device = None
for manufacturer in sorted(man_map, key=primary_sort_key):
devs = man_map[manufacturer]
m = QStandardItem(manufacturer)
@ -82,8 +80,6 @@ class Model(QStandardItemModel):
i.setData(dev)
i.setFlags(i.flags() | Qt.ItemFlag.ItemNeverHasChildren)
m.appendRow(i)
if dev.settings_key == lcd:
selected_device = i
def itermodels(self):
root = self.invisibleRootItem()

View File

@ -438,7 +438,6 @@ def web_search(ctx, rd, book_id, field, item_val):
with db.safe_read_lock:
if not ctx.has_id(rd, db, book_id):
raise BookNotFound(book_id, db)
mi = db.get_metadata(book_id, get_cover=False)
url, tooltip = web_search_link(db, book_id, field, item_val)
if url:
raise HTTPTempRedirect(url)