Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Clean up setting the preference controlling whether library view columns can be moved with the mouse. Use a checkbox to make the current state clearer.

Browse Source
This commit is contained in:
Charles Haley 2023-09-25 20:28:56 +01:00
parent 7bde152ed3
commit f68293c7dd
1 changed files with 12 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/calibre/gui2/library/views.py
View File

@ -500,12 +500,6 @@ class BooksView(QTableView): # {{{
gprefs['book_list_split'] = self.pin_view.isVisible() gprefs['book_list_split'] = self.pin_view.isVisible()
self.save_state() self.save_state()
return return
if action in ('lock', 'unlock'):
val = action == 'unlock'
self.column_header.setSectionsMovable(val)
self.pin_view.column_header.setSectionsMovable(val)
gprefs.set('allow_column_movement_with_mouse', val)
if not action or not column or not view: if not action or not column or not view:
return return
try: try:
@ -514,7 +508,12 @@ class BooksView(QTableView): # {{{
return return
h = view.column_header h = view.column_header
if action == 'hide': if action == 'lock':
val = not view.column_header.sectionsMovable()
self.column_header.setSectionsMovable(val)
self.pin_view.column_header.setSectionsMovable(val)
gprefs.set('allow_column_movement_with_mouse', val)
elif action == 'hide':
if h.hiddenSectionCount() >= h.count(): if h.hiddenSectionCount() >= h.count():
return error_dialog(self, _('Cannot hide all columns'), _( return error_dialog(self, _('Cannot hide all columns'), _(
'You must not hide all columns'), show=True) 'You must not hide all columns'), show=True)
@ -690,23 +689,13 @@ class BooksView(QTableView): # {{{
ac.setText(_('Un-split the book list')) ac.setText(_('Un-split the book list'))
else: else:
ac.setText(_('Split the book list')) ac.setText(_('Split the book list'))
# QIcon.ic('drm-locked.png'),
if not hasattr(m, 'column_mouse_move_action'):
m.column_mouse_move_action = m.addAction('xxx')
def set_action_attributes(icon, text, slot): ac = getattr(m, 'column_mouse_move_action', None)
m.column_mouse_move_action.setText(text) if ac is None:
m.column_mouse_move_action.setIcon(icon) ac = m.column_mouse_move_action = m.addAction(_("Allow moving columns with the mouse"),
m.column_mouse_move_action.triggered.connect(slot) partial(self.column_header_context_handler, action='lock', column=col, view=view))
ac.setCheckable(True)
if view.column_header.sectionsMovable(): ac.setChecked(view.column_header.sectionsMovable())
set_action_attributes(QIcon.ic('drm-locked.png'),
_("Don't allow moving columns with the mouse"),
partial(self.column_header_context_handler, action='lock'))
else:
set_action_attributes(QIcon.ic('drm-unlocked.png'),
_("Allow moving columns with the mouse"),
partial(self.column_header_context_handler, action='unlock'))
if has_context_menu: if has_context_menu:
view.column_header_context_menu.popup(view.column_header.mapToGlobal(pos)) view.column_header_context_menu.popup(view.column_header.mapToGlobal(pos))
# }}} # }}}