From f7a7dd649d4358660afc0ca709fc581ca080054d Mon Sep 17 00:00:00 2001
From: Kovid Goyal <kovid@kovidgoyal.net>
Date: Sat, 8 Nov 2014 10:07:44 +0530
Subject: [PATCH] Nicer error message when only failures are metadata updates

---
 src/calibre/gui2/save.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/calibre/gui2/save.py b/src/calibre/gui2/save.py
index 13b5b23693..278bbe8406 100644
--- a/src/calibre/gui2/save.py
+++ b/src/calibre/gui2/save.py
@@ -263,7 +263,11 @@ class Saver(QObject):
     def report(self):
         if not self.errors:
             return
-        if len(self.errors) == len(self.all_book_ids):
+        err_types = {e[0] for errors in self.errors.itervalues() for e in errors}
+        if err_types == {'metadata'}:
+            msg = _('Failed to update metadata in some books, click "Show details" for more information')
+            d = warning_dialog
+        elif len(self.errors) == len(self.all_book_ids):
             msg = _('Failed to save any books to disk, click "Show details" for more information')
             d = error_dialog
         else: