Kovid Goyal
f172c67706
./setup.py check now uses strict checking
...
No need to maintain two ruff configs. And strict checking happens in
editors/CI automatically, making my life a bit easier.
Remove the no longer needed --strict and --pep8 options from the check
command.
2025-01-26 10:35:19 +05:30
Kovid Goyal
c6c7ed4dbe
pep8
2025-01-26 10:14:58 +05:30
Kovid Goyal
90a97caa3b
Merge branch 'make-check-strict-happy' of https://github.com/un-pogaz/calibre
2025-01-26 10:10:15 +05:30
Kovid Goyal
5a0e9aae9e
Merge branch 'master' of https://github.com/cbhaley/calibre
2025-01-26 09:58:40 +05:30
Charles Haley
f939f85498
Improvement found while testing: give selected books to the formatter in CoverView.
2025-01-25 20:17:10 +00:00
Charles Haley
855520cc08
Redid all the changes that got lost somehow. Wish I understood what happened.
2025-01-25 14:54:11 +00:00
un-pogaz
73828a55ae
make "setup.py check --strict" happy
2025-01-25 15:44:09 +01:00
Charles Haley
f84b4a7829
Preferences / Look & feel changes
...
- Add infrastructure for automatic handling of lazy operations (now lazy_initialize). There is a new class LazyConfigWidgetBase that supports the lazy operations. It is a drop-in replacement for ConfigWidgetBase
- Convert tab widgets: tb display, tb_partitioning, quickview
Over time I will convert other look & feel tabs, if for no other reason than to speed up opening that set of preferences.
2025-01-25 12:14:45 +00:00
Kovid Goyal
c78cfdd926
Merge branch 'master' of https://github.com/cbhaley/calibre
2025-01-25 17:31:50 +05:30
Kovid Goyal
c10832387d
Cleanup previous PR
2025-01-25 17:31:21 +05:30
Charles Haley
4f0e469433
Fix bug in tag browser where cancelling a category icon file getter dialog removes the existing
2025-01-25 09:19:33 +00:00
Kovid Goyal
7e61ea2248
Merge branch 'ruff-pep8-strict' of https://github.com/un-pogaz/calibre
2025-01-25 13:56:37 +05:30
Kovid Goyal
2cfe2ba648
Add symbolic names for various known MTP error codes
2025-01-25 11:03:19 +05:30
Kovid Goyal
452058a4aa
DRYer
2025-01-25 10:36:21 +05:30
Kovid Goyal
bb6d43d7cd
Report bulk failures to stderr
2025-01-25 10:24:15 +05:30
Kovid Goyal
0c4dae5e89
When bulk get of properties fails retry with a single get
2025-01-25 10:19:06 +05:30
Kovid Goyal
4f01aa24e6
Ignore enumerable objects for which getting properties fails
...
Needed for the PoS Nook which apparently fails to return properties for
many objects. ALso matches libmtp based driver behavior.
2025-01-25 10:10:44 +05:30
Kovid Goyal
64e87a86a7
...
2025-01-25 10:03:52 +05:30
Kovid Goyal
968acc0a83
Dont use bulk property retrieval for Nook Glowlight 4N
...
See discussion in: https://bugs.launchpad.net/calibre/+bug/2068527
2025-01-25 09:52:30 +05:30
Kovid Goyal
66cf52e1c6
Dont ignore failures reported in OnEnd when doing bulk property queries
2025-01-25 09:36:16 +05:30
un-pogaz
f20aa37527
more string concatenation (extra-edit)
2025-01-24 11:14:25 +01:00
un-pogaz
8810c94933
implicit string concatenation (extra-edit)
2025-01-24 11:14:25 +01:00
un-pogaz
ac4fbfc7c9
implicit string concatenation (manual)
...
ruff 'ISC'
2025-01-24 11:14:25 +01:00
un-pogaz
ce83e97a7c
unnecessary return (extra-edit)
2025-01-24 11:14:25 +01:00
un-pogaz
0ee26c5e75
unnecessary return None (auto-fix)
...
ruff 'RET501'
2025-01-24 11:14:24 +01:00
un-pogaz
59cd38256a
useless tuple (extra-edit)
2025-01-24 11:14:24 +01:00
un-pogaz
ed2930712d
various whitespace (extra-edit)
...
!partial 'E203,E222,E241,E271,E272'
2025-01-24 11:14:24 +01:00
un-pogaz
41cee6f02d
various whitespace (auto-fix)
...
ruff 'E201,E202,E211,E251,E275'
2025-01-24 11:14:24 +01:00
un-pogaz
fb0a290127
remove duplicate class field definition (manual)
...
ruff 'PIE794'
2025-01-24 11:14:22 +01:00
un-pogaz
8dfbcaa057
more misc recomendation (extra-edit)
2025-01-24 11:14:22 +01:00
un-pogaz
ddfdc80d3a
more misc recomendation (manual)
...
ruff 'PIE'
2025-01-24 11:14:22 +01:00
un-pogaz
e006114716
more misc recomendation (auto-fix)
...
ruff 'PIE'
2025-01-24 11:14:21 +01:00
un-pogaz
b2c90ff460
convert docstrings comments (extra-edit)
2025-01-24 11:14:21 +01:00
un-pogaz
0ce6645f15
comment formating (extra-edit)
2025-01-24 11:14:21 +01:00
un-pogaz
dba73b96b7
comment formating (manual)
...
ruff 'E114,E115,E116,E261,E262,E265'
2025-01-24 11:14:21 +01:00
un-pogaz
19b9d979ab
comment formating (auto-fix)
...
ruff 'E114,E115,E116,E261,E262,E265'
2025-01-24 11:14:21 +01:00
un-pogaz
0b23eaf328
code indentation (extra-edit)
2025-01-24 11:14:21 +01:00
un-pogaz
8032201318
code indentation (manual)
...
ruff 'E111,E112,E113,E117'
2025-01-24 11:14:21 +01:00
un-pogaz
8d28380515
add/remove blank-line (extra-edit)
...
ruff 'E302,E303,E304,E305,W391'
2025-01-24 11:14:21 +01:00
un-pogaz
5540126765
uniform region (extra-edit)
2025-01-24 11:14:20 +01:00
un-pogaz
5f24dfb868
needless else (auto-fix)
...
ruff 'RUF047'
2025-01-24 11:14:20 +01:00
un-pogaz
07500e1ea3
always use raw-string for regex (extra-edit)
2025-01-24 11:14:20 +01:00
un-pogaz
3720de10d2
always use raw-string for regex (manual)
...
ruff 'RUF039'
2025-01-24 11:14:20 +01:00
un-pogaz
ac6912565a
always use raw-string for regex (auto-fix)
...
ruff 'RUF039'
2025-01-24 11:14:20 +01:00
un-pogaz
567a0187f3
unnecessary regex (manual)
...
ruff 'RUF055'
2025-01-24 11:14:20 +01:00
un-pogaz
bd59682f46
unnecessary regex (auto-fix)
...
ruff 'RUF055'
2025-01-24 11:14:20 +01:00
un-pogaz
7f6a11a368
useless dict operation (auto-fix)
...
ruff 'RUF051,RUF056'
2025-01-24 11:14:20 +01:00
un-pogaz
4aa2c3a342
enable preview mode
2025-01-24 11:14:20 +01:00
un-pogaz
dd35da54fd
useless if-else (manual)
...
ruff 'RUF034'
2025-01-24 11:14:20 +01:00
un-pogaz
dcc86ee4ef
explicit f-string conversion (extra-edit)
2025-01-24 11:14:20 +01:00
