Commit Graph

36890 Commits

Author SHA1 Message Date
Charles Haley 42e07a3b14 Small optimization of commit b43a329 2023-11-13 15:59:37 +00:00
Charles Haley fa9061660e Enhancement 2043330: Template function to fetch links
I put this in notes to avoid any hassle with collisions with the other new template functions.
2023-11-13 19:21:44 +05:30
Kovid Goyal bba616de82 Notes/comments editor: When right clicking on a link, add a menu item to open the link 2023-11-13 19:21:44 +05:30
Kovid Goyal d7a9c7f8f9 string changes 2023-11-13 19:21:44 +05:30
Kovid Goyal e7abf626bc Book details: Fix Manage authors via context menu not working 2023-11-13 19:21:44 +05:30
Kovid Goyal 8ea5281a47 Bump beta version 2023-11-13 19:21:44 +05:30
Kovid Goyal 81708d3614 Content server home page: Show the three most recently added books in the default library 2023-11-13 19:21:43 +05:30
Kovid Goyal 896df3daf9 Content server: Add button to return to books page at top level of controls 2023-11-13 19:21:43 +05:30
Kovid Goyal 512c1e34b3 Fix a regression that caused popup modals to no longer be horizontally centered 2023-11-13 19:21:43 +05:30
Charles Haley 3fa526fc8e Apologies -- I left some of the icons as class attributes. 2023-11-13 19:21:43 +05:30
Charles Haley bfdebb1c7e Icon cache changes:
1. Add an icon cache to QIcon.
2. Use the cache for every icon getter in these dialogs.
2023-11-13 19:21:43 +05:30
Kovid Goyal b5c649b4de Do not make icons class attributes
class attributes are evaluated at import time loading a bunch of icons
is an undesired side effect for simply importing code, not to mention
that I am not sure that the icon machinery will always be working
in all contexts where code is imported.
2023-11-13 19:21:43 +05:30
Charles Haley 27bea0a999 Several changes:
1. Improve performance by caching all icons.
2. Use different icons instead of a check mark for notes. Sorting uses the icon.
3. In manage tags, make the edit button on the left work on all editable cells. Correct the tooltip.
4. In manage tags, put the button press shortcut descriptions into the tooltips.
5. In manage authors, add an "Edit cell" button that works with all editable cells.
2023-11-13 19:21:43 +05:30
Charles Haley 07ceef1927 Set the focus to the table whenever it is rebuilt. Saves a lot of tabbing. 2023-11-13 19:21:43 +05:30
Charles Haley 1474957e99 Added the third radio button and made them exclusive.
I solved the vertical space problem by eliminating the content margins.
2023-11-13 19:21:43 +05:30
Charles Haley f176c4ac36 Add a "Show items in selected books" choice to manage tags and manage authors.
Radio buttons are more visually intuitive than checkboxes, but it is a little strange not having a "Use all" radio button. You click the radio button again to turn it off. Adding the third button takes up more vertical space than it is worth. Switching back to checkboxes is trivial.
2023-11-13 19:21:43 +05:30
Kovid Goyal b43a3295fb Cleanup previous PR 2023-11-13 19:21:43 +05:30
un-pogaz d40ceb1643 Use user custom icons 2023-11-13 19:21:43 +05:30
Charles Haley f55c0547a7 I broke publisher. Fixed. 2023-11-13 19:21:43 +05:30
Charles Haley c3ccacbf57 manage_categories: If the current cell is in a category, add editing notes and links for the book's individual items 2023-11-13 19:21:43 +05:30
Kovid Goyal f4db41bf82 Show note dialog: Fix links not being activated when clicked 2023-11-13 19:21:43 +05:30
Kovid Goyal 31611e434a More fts5 tests 2023-11-13 19:21:42 +05:30
Kovid Goyal 63a2fa9474 Revert removal of context menu for sandboxed iframes
The context menu is needed for copying text on mobile devices.
2023-11-13 19:21:42 +05:30
Kovid Goyal 909654fa39 Content server: Book details: Open links in comments fields in the same window rather than a new window 2023-11-13 19:21:42 +05:30
un-pogaz 7a5bf8be33 improve NotesUtilities 2023-11-13 19:21:42 +05:30
Kovid Goyal 705a11cd50 Bump beta version 2023-11-13 19:21:42 +05:30
Kovid Goyal a45267eaf4 fix notes editor changes in the HTML view not being saved until switching back to th enormal view 2023-11-13 19:21:42 +05:30
Kovid Goyal 768aabceb3 Fix a regression that broke the comments editor on the server 2023-11-13 19:21:42 +05:30
Kovid Goyal d124d50faf fix type signature 2023-11-13 19:21:42 +05:30
Charles Haley 3eb15353ec Changes to category editors:
- Eliminate the NotesItem class for performance
- Ensure the edited icon is displayed as appropriate
- Add context menus
- Lots of refactoring
- Bug fixes for tag_list... where changes were lost when the list was filtered

Opening authors and tags for the "big library" now takes at most a few seconds.

I will continue to test it. I wouldn't be surprised if I broke something.
2023-11-13 19:21:42 +05:30
Kovid Goyal 13d584cfb8 another return in conn.execute loop 2023-11-13 19:21:42 +05:30
Kovid Goyal e57840f244 ... 2023-11-13 19:21:42 +05:30
Kovid Goyal 00089388e1 Mark method as being read_api 2023-11-13 19:21:42 +05:30
Kovid Goyal a54c93a95d ... 2023-11-13 19:21:42 +05:30
Kovid Goyal e8d3e37208 When saving PDF in PoDoFo dont collect garbage to avoid slowdowns with some PDF files
See #2041745 (metadata in PDF very slow or gives errors)
2023-11-13 19:21:41 +05:30
Kovid Goyal 0cd441515b More misc category editor fixes 2023-11-13 19:21:41 +05:30
Kovid Goyal d296ce1e68 ... 2023-11-13 19:21:41 +05:30
Kovid Goyal 814708da49 Minor cleanups 2023-11-13 19:21:41 +05:30
Kovid Goyal 4903e69ade Implement performant editing with undo for notes in manage authors dialog 2023-11-13 19:21:41 +05:30
Kovid Goyal 823ec12f02 Fix sorting by notes column in manage category dialogs
Also remove the notesitemwidget as its performance is unacceptable
2023-11-13 19:21:41 +05:30
Kovid Goyal b9e24ffb07 More speedups for NotesItemWidget 2023-11-13 19:21:41 +05:30
Kovid Goyal a292113f0b Some speedups for NotesItemWidget 2023-11-13 19:21:41 +05:30
Kovid Goyal f490fec3f9 pep8 2023-11-13 19:21:41 +05:30
Kovid Goyal c25d6c3932 Bump beta version 2023-11-13 19:21:41 +05:30
Kovid Goyal bbf85a760b Fix CS note editing not updating the book details view after edit 2023-11-13 19:21:41 +05:30
Kovid Goyal 1bbd823c32 Fix focus not returning to popup book details window after show notes 2023-11-13 19:21:41 +05:30
Kovid Goyal e1acdb6237 Implement image sizes for cs comments editor as well 2023-11-13 19:21:41 +05:30
Kovid Goyal c1ca6616bd Notes editor: Allow specifying image sizes 2023-11-13 19:21:41 +05:30
Kovid Goyal 3d7d07ed78 Fix BonJour registration for smart device driver not working 2023-11-13 19:21:40 +05:30
Kovid Goyal 1ca9ef022f Fix vaccuming of notesdb broken 2023-11-13 19:21:40 +05:30