Commit Graph

33624 Commits

Author SHA1 Message Date
Kovid Goyal dc88a74caa Oops, forgot to move test for lock failure above cache access 2021-05-06 15:18:11 +05:30
Kovid Goyal 5ff45a7ee7 Hold the VLs cache lock when checking if the cache exists 2021-05-06 07:26:02 +05:30
Kovid Goyal e9ee3e0546 Use a context manager for vls_cache_lock 2021-05-06 07:21:50 +05:30
Charles Haley 312e44dc3b Ensure that updating the vl_book cache is both thread safe and recursion safe. 2021-05-05 18:59:45 +01:00
Kovid Goyal 0a6010e712 No need to explicitly get the write lock since clear_composite_caches gets it for us 2021-05-05 22:06:32 +05:30
Kovid Goyal 1f50076bb8 When trying to upgrade a shared lock a LockingError is raised not a DowngradeError 2021-05-05 21:52:13 +05:30
Kovid Goyal d8918f1dd8 Merge branch 'master' of https://github.com/cbhaley/calibre
Fix #1927179 [VL set to wildcard crashes Calibre](https://bugs.launchpad.net/calibre/+bug/1927179)
2021-05-05 21:43:52 +05:30
Charles Haley 224d3a68fa Get a write lock to clear the composite caches. Fail gracefully if we can't get the lock. 2021-05-05 16:46:05 +01:00
Charles Haley 7a07fcbc48 Bug #1927179: VL set to wildcard crashes Calibre. Note that the problem had nothing to do with wildcards. It was triggered by an unanchored search specification (one with no column), which caused all the composite columns to be evaluated. 2021-05-05 13:43:38 +01:00
Kovid Goyal 94a6fcadcf String changes 2021-05-05 16:31:00 +05:30
Kovid Goyal 48a59e1333 Add an abort button to the confirmation for moving large numbers of books to the recycle bin 2021-05-05 15:10:32 +05:30
Kovid Goyal ae09f4bacc Merge branch 'metainfo' of https://github.com/qykth-git/calibre 2021-05-05 10:01:38 +05:30
Kovid Goyal 28f16bec0f Fix #1927167 [Book details window: Dark mode background reverts after deleting metadata](https://bugs.launchpad.net/calibre/+bug/1927167) 2021-05-05 09:29:47 +05:30
YOKOTA Hiroshi 53eb001ac1 Fix AppStream warnings
This fix provides proper "lang" attribute in "description" tag.
2021-05-05 12:46:53 +09:00
Charles Haley f6de283e7b Ooops ... 2021-05-04 20:08:49 +01:00
Charles Haley 9827755a9e Bug #1927141: Exception when search testing the length of an is_multiple composite
I made get_metadata a keyword argument for compatibility. There are no other uses in base calibre, but ...
2021-05-04 20:07:04 +01:00
Kovid Goyal 6279cd7f2f ... 2021-05-04 20:34:56 +05:30
Kovid Goyal 3bbbd5958d Review downloaded metadata: Allow double clicking on a cover to see it at a larger size. Fixes #1927062 [Enhancement Request: Review Metadata: Option to view cover full size](https://bugs.launchpad.net/calibre/+bug/1927062) 2021-05-04 15:54:37 +05:30
Kovid Goyal 13c27b9fdd Annotations browser: Add a Refresh button. Fixes #1927012 [[Enhancement] Refresh highlights and bookmarks in the Annotations browser](https://bugs.launchpad.net/calibre/+bug/1927012) 2021-05-04 14:55:25 +05:30
Kovid Goyal cb45bbe591 Allow specifying default dialog buttons 2021-05-04 11:43:48 +05:30
Kovid Goyal 62a092fd57 Fix #1927010 [[Enhancement] Add shortcut to edit notes in the Annotations browser](https://bugs.launchpad.net/calibre/+bug/1927010) 2021-05-04 11:03:07 +05:30
Kovid Goyal 11d62a8e6b Fix #1927011 [[Enhancement] Place the cursor at the end of the Edit notes for highlight window](https://bugs.launchpad.net/calibre/+bug/1927011) 2021-05-04 10:50:45 +05:30
Kovid Goyal ac800859ff DRYer 2021-05-04 10:46:33 +05:30
Kovid Goyal dd3179734d Edit metadata: Comments editor: Add a shortcut (Ctrl+L) to insert a link. Fixes #1927008 [feature request: keybinding for "Insert link or image"](https://bugs.launchpad.net/calibre/+bug/1927008) 2021-05-04 10:30:22 +05:30
Kovid Goyal 93e3ddab91 Book details popup: Use the general window color as background for the cover 2021-05-04 08:57:48 +05:30
Kovid Goyal 889b5f556f ... 2021-05-03 12:07:35 +05:30
Kovid Goyal cb083f31ab E-book viewer: Fix sorting bookmarks by title not working 2021-05-03 11:35:09 +05:30
Kovid Goyal 8aff658a0a Windows WPD driver: Fix an error reading the filesystem on some MTP based devices
At least I hope retaining a reference to the bulk properties callback
while processing events fixes it. Also add a better error message when
waiting fails. Fixes #1926900 [send to device winerror6](https://bugs.launchpad.net/calibre/+bug/1926900)
2021-05-03 09:29:51 +05:30
Kovid Goyal 7f21e3692e Fix #1926852 [[Enhancement] Warn before removing news source from the Add custom news sources window](https://bugs.launchpad.net/calibre/+bug/1926852) 2021-05-02 13:48:39 +05:30
Kovid Goyal 5d73aa715f Fix #1926859 [Enhancement Request: Book details: Copy identifier URL](https://bugs.launchpad.net/calibre/+bug/1926859) 2021-05-02 13:03:51 +05:30
Kovid Goyal 8af9e5181c Fix #1926857 [[Enhancement - Viewer] Add popups when hovering to control buttons](https://bugs.launchpad.net/calibre/+bug/1926857) 2021-05-02 09:25:40 +05:30
Kovid Goyal d8410f1c4a Fix #1926851 [[Enhancement - Viewer] Double-click on image to fit/unfit image](https://bugs.launchpad.net/calibre/+bug/1926851) 2021-05-02 09:10:32 +05:30
Kovid Goyal e5b034b8c5 Embedded content server: Ignore corrupted settings files 2021-05-01 16:56:46 +05:30
Kovid Goyal 1fa94ec5c2 Merge branch 'mobi' of https://github.com/xxyzz/calibre 2021-05-01 11:03:41 +05:30
xxyzz c20f4a43f1 add optional parameter asin to MetadataUpdater.update() 2021-05-01 13:08:11 +08:00
Kovid Goyal b8e128271d E-book viewer: Speed up initialisation of WebEngine
Prevent the viewer JavaScript from being loaded multiple times on the
various iframes. Also only create the iframe used for the footnote
popups on demand.
2021-05-01 10:26:50 +05:30
Kovid Goyal 9a3a8bd271 Fix #1926785 ["Remove unused CCS rules" behaviour](https://bugs.launchpad.net/calibre/+bug/1926785) 2021-04-30 22:05:47 +05:30
Guido Falsi 545942981f Fix reinterpret_cast usage with clang.
In FreeBSD with clang, NULL is redefined to nullptr since freebsd/freebsd-src@c8ed04c

static_cast should be used in this case.

This fixes build with clang on FreeBSD and should not cause any issues with other compilers.
2021-04-30 18:05:59 +02:00
Kovid Goyal b15117ce2b Fix building on windows 32bit 2021-04-30 07:30:12 +05:30
Kovid Goyal 2ae7b84161 version 5.17.0 2021-04-30 06:55:31 +05:30
Kovid Goyal 87a3a6e31e Bump plugin version 2021-04-29 20:51:26 +05:30
William Ouwehand dfca7b5721 Fixed Gutenberg-store search issue (missing author names)
Collected works may lack the author name field, and its HTML div. This
interrupted the search results processing.

For example, searching on title or author using "erasmus" yielded no or
two results out of 25 max.

- Title search now works as expected.
- Author search omits discussed results. Apparently at a later stage a
match is required between 's.author' and the query.
2021-04-29 16:44:09 +02:00
Kovid Goyal e5654c1c4f Allow double clicking int he customize viewer toolbar dialog 2021-04-29 19:48:09 +05:30
Kovid Goyal 9e34e107ab Fix #1926607 [[Enhancement - Viewer] Turn X red when hovering the Close button of the controls](https://bugs.launchpad.net/calibre/+bug/1926607) 2021-04-29 19:16:22 +05:30
Kovid Goyal 352a07d5fc Also add expand all/collapse all context menu to shortcuts view 2021-04-29 14:24:44 +05:30
Kovid Goyal dc1437c2bb Dont allow drag-to-pan when image fits
Also use "natural" direction when panning
2021-04-29 07:45:32 +05:30
Kovid Goyal 0f51fe1f66 E-book viewer: Image popup: Allow dragging with the mouse to pan the image. Fixes #1926484 [[Enhancement] E-book viewer: new mouse actions for the View image window](https://bugs.launchpad.net/calibre/+bug/1926484) 2021-04-29 07:39:16 +05:30
Kovid Goyal 4a7016f020 Fix #1926320 [[Enhancement] Show shortcuts in context menu of Book details panel](https://bugs.launchpad.net/calibre/+bug/1926320) 2021-04-29 06:54:36 +05:30
Kovid Goyal 1471322f49 E-book viewer: The quick highlight button should replace the style of an existing highlight, when one is selected. Fixes #1926518 [[Viewer] Quick highlighting a already highlighted text should replace the original highlighting](https://bugs.launchpad.net/calibre/+bug/1926518) 2021-04-29 06:49:03 +05:30
Kovid Goyal f0f7256e7b Fix #1926516 [[Enhancement - Viewer] Use uppercase letters for shortcuts in the selection bar](https://bugs.launchpad.net/calibre/+bug/1926516) 2021-04-29 06:29:14 +05:30