41038 Commits

Author SHA1 Message Date
Kovid Goyal
dd3810f6f4
Cancel button on edit notes now works 2020-08-22 18:48:26 +05:30
Kovid Goyal
df352ba239
Fix right click menus in text fields not working in desktop viewer 2020-08-22 18:48:26 +05:30
Kovid Goyal
b8e04661b7
Specialize accept button text based on whether we are editing a current annotation or not 2020-08-22 18:48:26 +05:30
Kovid Goyal
5d63ddfc03
Make the edit panel smaller 2020-08-22 18:48:26 +05:30
Kovid Goyal
136a9f64ec
Fix editor being closed on resize 2020-08-22 18:48:26 +05:30
Kovid Goyal
95248db34e
Make finding highlights overlapping the selection O(n) in the size of the selection rather than the number of existing highlights 2020-08-22 18:48:26 +05:30
Kovid Goyal
1d04aa3d44
Get the editor panel properly positioned 2020-08-22 18:48:25 +05:30
Kovid Goyal
8fa67e7bfd
Track annot over entire selection
Also work on notes/color editor panel
2020-08-22 18:48:25 +05:30
Kovid Goyal
1ce8b68de6
Remove the create_annotation module
The entire UI is being removed since all operations will be performed
via the selection bar
2020-08-22 18:48:25 +05:30
Kovid Goyal
948acd6a55
Move AnnotationsManager into the annotations module 2020-08-22 18:48:25 +05:30
Kovid Goyal
2668212179
Remove adjust selection action 2020-08-22 18:48:25 +05:30
Kovid Goyal
4f68fb39fc
Allow dragging of selection handles 2020-08-22 18:48:25 +05:30
Kovid Goyal
a0b6979fbf
Show selection handles with selection bar 2020-08-22 18:48:25 +05:30
Kovid Goyal
258cec5889
Bump CI python version 2020-08-22 18:48:25 +05:30
Kovid Goyal
e117b2c849
Enable auto update of translations on transifex 2020-08-22 18:48:25 +05:30
Kovid Goyal
7bfaa55381
Add a note on how to sync annots with the browser viewer 2020-08-22 18:48:25 +05:30
Kovid Goyal
3c4fb4f4ef
Indicate current olor on quick highlight icon 2020-08-22 18:48:24 +05:30
Kovid Goyal
8d4744c3e4
Change icon of remove highlight to trash can
Consistent with other remove buttons
2020-08-22 18:48:24 +05:30
Kovid Goyal
185e331e95
Fix browse annotations empty on ever second invocation 2020-08-22 18:48:24 +05:30
Kovid Goyal
265a620bee
Fix Edit button in highlights panel not working
I dont know why defaultView is undefined, seems like a chrome bug
2020-08-22 18:48:24 +05:30
Kovid Goyal
8eca4d7ced
Retry vendored dependency download failures on CI
GitHub Actions is getting insanely flaky
2020-08-22 18:48:24 +05:30
Kovid Goyal
bc8d76cfef
Fix sphinx error about duplicate definition of Tool 2020-08-22 18:48:24 +05:30
Kovid Goyal
6af3aefb50
Fix sphinx deprecation warning 2020-08-22 18:48:24 +05:30
Kovid Goyal
898169d270
Bump beta version 2020-08-22 18:48:24 +05:30
Kovid Goyal
86debe8dd0
Dont show selection bar during drag scroll 2020-08-22 18:48:24 +05:30
Kovid Goyal
7f275c8dc4
Add quick highlight and adjust selection actions for selection bar 2020-08-22 18:48:23 +05:30
Kovid Goyal
53da449b42
UI for customizing selection bar 2020-08-22 18:48:23 +05:30
Kovid Goyal
393e47dcdb
Add a remove highlight action to the popup bar
Only visible if a highlight is selected
2020-08-22 18:48:23 +05:30
Kovid Goyal
6746d0bc11
Make selection bar configurable 2020-08-22 18:48:23 +05:30
Kovid Goyal
4fb62e9565
Allow multi-select in viewer highlights panel
Useful to delete more than one highlight at a time
2020-08-22 18:48:23 +05:30
Kovid Goyal
ebb83d97b8
Clicking outside middle should act like clicking the finish button not the adjust selection button 2020-08-22 18:48:23 +05:30
Kovid Goyal
8de5a4ed86
Browser viewer: Fix context menu not working in input controls 2020-08-22 18:48:23 +05:30
Kovid Goyal
cbbcec8525
Clicking selection bar buttons should not steal focus from iframe 2020-08-22 18:48:23 +05:30
Kovid Goyal
cbdaad0003
Allow configuring the search URL 2020-08-22 18:48:23 +05:30
Kovid Goyal
83d5865d4c
Show the highlight and lookup actions if the selection bar is disabled 2020-08-22 18:48:23 +05:30
Kovid Goyal
dd3dad6cb6
Revert "Remove lookup and highlight actions from chrome"
This reverts commit c7d9ae13e2b05167c82485934112f128466fe826.
2020-08-22 18:48:22 +05:30
Kovid Goyal
20b76a0ae7
Add a preference to turn off the selection popup bar 2020-08-22 18:48:22 +05:30
Kovid Goyal
0848740051
misc cleanups for RTL merge 2020-08-22 18:48:22 +05:30
Kovid Goyal
a681d71608
Document that currently flow mode does not care about RTL/LTR 2020-08-22 18:48:22 +05:30
Kovid Goyal
769ca0c59f
Avoid multiple calls to getComputedStyle() 2020-08-22 18:48:22 +05:30
Kovid Goyal
b0e1506976
ltr and rtl should both be properties
Otherwise its easy to forget which is which
2020-08-22 18:48:22 +05:30
Kovid Goyal
1001f254a3
Only set transform is needed
Probably browsers dont do anything if the value doesn't change anyway,
but I'd rather not rely on that
2020-08-22 18:48:22 +05:30
Mark W. Gabby-Li
d9a343dad6
Support for Books in RTL Languages, Such as Hebrew
Three parts: RTL layout support, made inputs behave naturally in RTL modes, and updated tutorial for RTL books.

To add RTL layout support:
 ‣ Don't force LTR layout on DOM when loading.
 ‣ Disable "overflow: hidden" in RTL mode to compensate for an issue in Chrome, and disable scrollbars on all browsers to compensate for the side effect of this turning on scrollbars.
 ‣ Have viewport hide the RTL mode by negating scrolls and viewport position requests in RTL mode.
 ‣ Initialize viewport in paged mode layout so that it properly saves RTL mode.
 ‣ Remove all raw calls to pageXOffset and pageYOffset
 ‣ Put viewport_to_document in ScrollViewport so that it can abstract away RTL mode in this case, too.
   ‣ Get rid of calls to reset_transforms and make it private, since it is only called to prepare for viewport_to_document. Put the call there, instead.
 ‣ Use bounding box right instead of left for position of various elements when the viewport is in RTL mode, since the right side is the beginning of the element in this case.

To made input behave naturally in RTL:
 ‣ Get page progression direction from ePub.
 ‣ Add rtl_page_progression() function to return whether we're in this mode.
 ‣ Added support to tell page advance functions whether they should flip their direction if RTL is on.
 ‣ Changed touch behavior to support different position for going back and forward in RTL books.

Tutorial changes:
 ‣ Flipped tutorial so that next and previous page are reversed in position and size in RTL mode.
 ‣ Added a new counter so that RTL tutorial is shown even if user has already seen LTR tutorial.
2020-08-22 18:48:22 +05:30
Kovid Goyal
72173970da
Replace use of magic constant since it is available as a named constant in py3 2020-08-22 18:48:22 +05:30
Kovid Goyal
d8979c20cb
The copy button in the selection bar should work in the browser viewer as well 2020-08-22 18:48:22 +05:30
Kovid Goyal
593d652150
Fix restrictions dropdown not being initialized when using annots browser from within main GUI 2020-08-22 18:48:21 +05:30
Kovid Goyal
2316f291e0
Fix combination of type and user restriction not working 2020-08-22 18:48:21 +05:30
Kovid Goyal
01f14b8928
Bump beta version 2020-08-22 18:48:21 +05:30
Kovid Goyal
d90e866e9b
Limit the amount of highlighted text displayed in the highlights panel 2020-08-22 18:48:21 +05:30
Kovid Goyal
1fcd002121
Adjust documentation for new selection bar 2020-08-22 18:48:21 +05:30