From 01f52c9021f296fcbc867d88cb9b2392e5955df4 Mon Sep 17 00:00:00 2001 From: Ben <45583362+ben-basten@users.noreply.github.com> Date: Sat, 1 Jun 2024 22:58:35 +0000 Subject: [PATCH] chore(web): unique ID generation (#9932) * chore(web): automatically generate unique IDs * fix: revert changes to Slider * chore: add test for id store --- .../admin-page/delete-confirm-dialogue.svelte | 1 - .../admin-page/restore-dialogue.svelte | 1 - .../settings/auth/auth-settings.svelte | 19 ++---------------- .../settings/ffmpeg/ffmpeg-settings.svelte | 3 --- .../settings/image/image-settings.svelte | 2 -- .../library-settings/library-settings.svelte | 2 -- .../logging-settings/logging-settings.svelte | 8 +------- .../machine-learning-settings.svelte | 4 ---- .../settings/map-settings/map-settings.svelte | 2 -- .../new-version-check-settings.svelte | 1 - .../notification-settings.svelte | 2 -- .../storage-template-settings.svelte | 2 -- .../trash-settings/trash-settings.svelte | 1 - .../album-page/album-options.svelte | 3 +-- .../album-page/share-info-modal.svelte | 4 +--- .../album-page/user-selection-modal.svelte | 2 +- .../faces-page/merge-suggestion-modal.svelte | 2 +- .../faces-page/set-birth-date-modal.svelte | 2 +- .../lib/components/forms/api-key-form.svelte | 2 +- .../components/forms/api-key-secret.svelte | 2 +- .../components/forms/create-user-form.svelte | 2 +- .../components/forms/edit-album-form.svelte | 2 +- .../components/forms/edit-user-form.svelte | 2 +- .../library-exclusion-pattern-form.svelte | 7 +------ .../forms/library-import-path-form.svelte | 2 +- .../forms/library-user-picker-form.svelte | 7 +------ .../map-page/map-settings-modal.svelte | 16 ++++++--------- .../photos-page/delete-asset-dialog.svelte | 1 - .../album-selection-modal.svelte | 2 +- .../shared-components/change-date.svelte | 9 +-------- .../shared-components/change-location.svelte | 1 - .../shared-components/combobox.svelte | 9 +++++---- .../create-shared-link-modal.svelte | 20 ++++++------------- .../dialog/confirm-dialog.svelte | 3 +-- .../full-screen-modal.svelte | 11 +++++----- .../navigation-bar/avatar-selector.svelte | 2 +- .../profile-image-cropper.svelte | 2 +- .../search-bar/search-camera-section.svelte | 2 -- .../search-bar/search-location-section.svelte | 3 --- .../settings/setting-combobox.svelte | 2 -- .../settings/setting-switch.svelte | 4 +++- .../shared-components/show-shortcuts.svelte | 7 +------ .../version-announcement-box.svelte | 2 +- .../lib/components/slideshow-settings.svelte | 4 ++-- .../user-settings-page/app-settings.svelte | 9 --------- .../memories-settings.svelte | 1 - .../partner-selection-modal.svelte | 2 +- .../partner-settings.svelte | 1 - web/src/lib/stores/unique-id.store.spec.ts | 14 +++++++++++++ web/src/lib/stores/unique-id.store.ts | 16 +++++++++++++++ web/src/routes/(user)/people/+page.svelte | 2 +- .../routes/admin/user-management/+page.svelte | 1 - 52 files changed, 83 insertions(+), 150 deletions(-) create mode 100644 web/src/lib/stores/unique-id.store.spec.ts create mode 100644 web/src/lib/stores/unique-id.store.ts diff --git a/web/src/lib/components/admin-page/delete-confirm-dialogue.svelte b/web/src/lib/components/admin-page/delete-confirm-dialogue.svelte index 8436935cae..004f8deeed 100644 --- a/web/src/lib/components/admin-page/delete-confirm-dialogue.svelte +++ b/web/src/lib/components/admin-page/delete-confirm-dialogue.svelte @@ -43,7 +43,6 @@ {#if isConfirmOpen} - (isConfirmOpen = false)} - onConfirm={() => handleSave(true)} - > + (isConfirmOpen = false)} onConfirm={() => handleSave(true)}>

Are you sure you want to disable all login methods? Login will be completely disabled.

@@ -82,13 +77,7 @@ >.

- + {#if config.oauth.enabled}
@@ -177,7 +166,6 @@ />
- +
- dispatch('close')}> + dispatch('close')}>

SETTINGS

@@ -64,7 +64,6 @@ /> {/if} {#if !selectedRemoveUser} - +
@@ -156,7 +156,6 @@ {#if selectedRemoveUser && selectedRemoveUser?.id === currentUser?.id} - + {#if Object.keys(selectedUsers).length > 0}

SELECTED

diff --git a/web/src/lib/components/faces-page/merge-suggestion-modal.svelte b/web/src/lib/components/faces-page/merge-suggestion-modal.svelte index e29e49711a..6fe603eeb0 100644 --- a/web/src/lib/components/faces-page/merge-suggestion-modal.svelte +++ b/web/src/lib/components/faces-page/merge-suggestion-modal.svelte @@ -30,7 +30,7 @@ }; - dispatch('close')}> + dispatch('close')}>
{#if !choosePersonToMerge}
diff --git a/web/src/lib/components/faces-page/set-birth-date-modal.svelte b/web/src/lib/components/faces-page/set-birth-date-modal.svelte index 810ec9b073..1433852c90 100644 --- a/web/src/lib/components/faces-page/set-birth-date-modal.svelte +++ b/web/src/lib/components/faces-page/set-birth-date-modal.svelte @@ -20,7 +20,7 @@ }; - +

Date of birth is used to calculate the age of this person at the time of a photo. diff --git a/web/src/lib/components/forms/api-key-form.svelte b/web/src/lib/components/forms/api-key-form.svelte index 8fcf547fe5..07fcd0ffdf 100644 --- a/web/src/lib/components/forms/api-key-form.svelte +++ b/web/src/lib/components/forms/api-key-form.svelte @@ -28,7 +28,7 @@ }; - +

diff --git a/web/src/lib/components/forms/api-key-secret.svelte b/web/src/lib/components/forms/api-key-secret.svelte index f01758de26..5a77630a1a 100644 --- a/web/src/lib/components/forms/api-key-secret.svelte +++ b/web/src/lib/components/forms/api-key-secret.svelte @@ -13,7 +13,7 @@ const handleDone = () => dispatch('done'); - handleDone()}> + handleDone()}>

This value will only be shown once. Please be sure to copy it before closing the window. diff --git a/web/src/lib/components/forms/create-user-form.svelte b/web/src/lib/components/forms/create-user-form.svelte index 5a8c8dc37b..4dbf55d7a5 100644 --- a/web/src/lib/components/forms/create-user-form.svelte +++ b/web/src/lib/components/forms/create-user-form.svelte @@ -74,7 +74,7 @@ } - +

diff --git a/web/src/lib/components/forms/edit-album-form.svelte b/web/src/lib/components/forms/edit-album-form.svelte index bfd7b43260..f983beefe8 100644 --- a/web/src/lib/components/forms/edit-album-form.svelte +++ b/web/src/lib/components/forms/edit-album-form.svelte @@ -36,7 +36,7 @@ }; - +