fix(web): clear unsaved asset description when changing asset (#26255)

* fix(web): clear unsaved asset description when changing asset

* remove unneeded $derived
This commit is contained in:
Michel Heusschen 2026-02-16 18:25:13 +01:00 committed by GitHub
parent cc9c261fd0
commit 0da74569f2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 67 additions and 2 deletions

View File

@ -0,0 +1,65 @@
import { assetFactory } from '@test-data/factories/asset-factory';
import '@testing-library/jest-dom';
import { render, screen } from '@testing-library/svelte';
import userEvent from '@testing-library/user-event';
import DetailPanelDescription from './detail-panel-description.svelte';
describe('DetailPanelDescription', () => {
it('clears unsaved draft on asset change', async () => {
const user = userEvent.setup();
const assetA = assetFactory.build({
id: 'asset-a',
exifInfo: { description: '' },
});
const assetB = assetFactory.build({
id: 'asset-b',
exifInfo: { description: '' },
});
const { rerender } = render(DetailPanelDescription, {
props: {
asset: assetA,
isOwner: true,
},
});
const textarea = screen.getByTestId('autogrow-textarea') as HTMLTextAreaElement;
await user.type(textarea, 'unsaved draft');
expect(textarea).toHaveValue('unsaved draft');
await rerender({
asset: assetB,
isOwner: true,
});
expect(screen.getByTestId('autogrow-textarea')).toHaveValue('');
});
it('updates description on asset switch', async () => {
const assetA = assetFactory.build({
id: 'asset-a',
exifInfo: { description: 'first description' },
});
const assetB = assetFactory.build({
id: 'asset-b',
exifInfo: { description: 'second description' },
});
const { rerender } = render(DetailPanelDescription, {
props: {
asset: assetA,
isOwner: true,
},
});
expect(screen.getByTestId('autogrow-textarea')).toHaveValue('first description');
await rerender({
asset: assetB,
isOwner: true,
});
expect(screen.getByTestId('autogrow-textarea')).toHaveValue('second description');
});
});

View File

@ -13,10 +13,10 @@
let { asset, isOwner }: Props = $props();
let currentDescription = $derived(asset.exifInfo?.description ?? '');
let description = $derived(currentDescription);
let description = $derived(asset.exifInfo?.description ?? '');
const handleFocusOut = async () => {
const currentDescription = asset.exifInfo?.description ?? '';
if (description === currentDescription) {
return;
}