From 0df910c0cd68887f0f64cb4b5d811268a3ab872f Mon Sep 17 00:00:00 2001
From: bo0tzz <git@bo0tzz.me>
Date: Tue, 2 Sep 2025 16:04:07 +0200
Subject: [PATCH] fix: don't run close-dupes workflow unnecessarily (#21333)

---
 .github/workflows/close-duplicates.yml | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/close-duplicates.yml b/.github/workflows/close-duplicates.yml
index 1cc646961b..b3411351a3 100644
--- a/.github/workflows/close-duplicates.yml
+++ b/.github/workflows/close-duplicates.yml
@@ -8,8 +8,18 @@ name: Close likely duplicates
 permissions: {}
 
 jobs:
+  should_run:
+    runs-on: ubuntu-latest
+    outputs:
+      should_run: ${{ steps.should_run.outputs.run }}
+    steps:
+      - id: should_run
+        run: echo "run=${{ github.event_name == 'issues' || github.event.discussion.category.name == 'Feature Request' }}" >> $GITHUB_OUTPUT
+
   get_body:
     runs-on: ubuntu-latest
+    needs: should_run
+    if: ${{ needs.should_run.outputs.should_run == 'true' }}
     env:
       EVENT: ${{ toJSON(github.event) }}
     outputs:
@@ -22,7 +32,8 @@ jobs:
 
   get_checkbox_json:
     runs-on: ubuntu-latest
-    needs: get_body
+    needs: [get_body, should_run]
+    if: ${{ needs.should_run.outputs.should_run == 'true' }}
     container:
       image: yshavit/mdq:0.8.0@sha256:c69224d34224a0043d9a3ee46679ba4a2a25afaac445f293d92afe13cd47fcea
     outputs:
@@ -31,14 +42,15 @@ jobs:
       - id: get_checkbox
         env:
           BODY: ${{ needs.get_body.outputs.body }}
+        # TODO: We should detect if the checkbox is missing entirely and also close_and_comment in that case.
         run: |
           JSON=$(echo "$BODY" | base64 -d | /mdq --output json '# I have searched | - [?] Yes')
           echo "json=$JSON" >> $GITHUB_OUTPUT
 
   close_and_comment:
     runs-on: ubuntu-latest
-    needs: get_checkbox_json
-    if: ${{ !fromJSON(needs.get_checkbox_json.outputs.json).items[0].list[0].checked }}
+    needs: [get_checkbox_json, should_run]
+    if: ${{ needs.should_run.outputs.should_run == 'true' && !fromJSON(needs.get_checkbox_json.outputs.json).items[0].list[0].checked }}
     permissions:
       issues: write
       discussions: write