From 1689cecaf74f902f524caba88a034e0a98d4c95f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mangat=20Singh=20Toor=20=7C=20=E0=A8=AE=E0=A9=B0=E0=A8=97?= =?UTF-8?q?=E0=A8=A4=20=E0=A8=B8=E0=A8=BF=E0=A9=B0=E0=A8=98=20=E0=A8=A4?= =?UTF-8?q?=E0=A9=82=E0=A8=B0?= Date: Mon, 17 Feb 2025 07:49:30 -0800 Subject: [PATCH] fix: include live images in person view count (#16116) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: include live images in person view count Fixed an issue where the total image count in the person view excluded live images. The query now correctly accounts for all relevant assets by removing the condition that filtered out assets with a livePhotoVideoId. Issue: - Image count under a person’s name was inaccurate, showing only static images. Fix: - Removed `.on('assets.livePhotoVideoId', 'is', null)` from the LEFT JOIN condition. Tested on: - Web Ran PR checklist * chore: run make sql. --------- Co-authored-by: Alex --- server/src/queries/person.repository.sql | 1 - server/src/repositories/person.repository.ts | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/server/src/queries/person.repository.sql b/server/src/queries/person.repository.sql index 2c06d7c3f2..069d965202 100644 --- a/server/src/queries/person.repository.sql +++ b/server/src/queries/person.repository.sql @@ -169,7 +169,6 @@ from and "asset_faces"."personId" = $1 and "assets"."isArchived" = $2 and "assets"."deletedAt" is null - and "assets"."livePhotoVideoId" is null -- PersonRepository.getNumberOfPeople select diff --git a/server/src/repositories/person.repository.ts b/server/src/repositories/person.repository.ts index b862d66f8a..751f9138e6 100644 --- a/server/src/repositories/person.repository.ts +++ b/server/src/repositories/person.repository.ts @@ -314,8 +314,7 @@ export class PersonRepository { .onRef('assets.id', '=', 'asset_faces.assetId') .on('asset_faces.personId', '=', personId) .on('assets.isArchived', '=', false) - .on('assets.deletedAt', 'is', null) - .on('assets.livePhotoVideoId', 'is', null), + .on('assets.deletedAt', 'is', null), ) .select((eb) => eb.fn.count(eb.fn('distinct', ['assets.id'])).as('count')) .executeTakeFirst();