From 24a4cba9535e8b8dcd03091829926614b1092159 Mon Sep 17 00:00:00 2001 From: shenlong <139912620+shenlong-tanwen@users.noreply.github.com> Date: Thu, 26 Jun 2025 07:58:17 +0530 Subject: [PATCH] fix: enable photo manager custom filter by default (#19520) enable photo manager custom filter by default Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com> --- .../lib/repositories/album_media.repository.dart | 2 +- mobile/lib/services/app_settings.service.dart | 2 +- mobile/lib/utils/migration.dart | 16 ++++++++++------ 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/mobile/lib/repositories/album_media.repository.dart b/mobile/lib/repositories/album_media.repository.dart index b3d31f4a1b..94f1d0581e 100644 --- a/mobile/lib/repositories/album_media.repository.dart +++ b/mobile/lib/repositories/album_media.repository.dart @@ -14,7 +14,7 @@ class AlbumMediaRepository { const AlbumMediaRepository(); bool get useCustomFilter => - Store.get(StoreKey.photoManagerCustomFilter, false); + Store.get(StoreKey.photoManagerCustomFilter, true); FilterOptionGroup? _getAlbumFilter({ DateTimeCond? updateTimeCond, diff --git a/mobile/lib/services/app_settings.service.dart b/mobile/lib/services/app_settings.service.dart index 76fd5e1ff6..8d1f7c24a5 100644 --- a/mobile/lib/services/app_settings.service.dart +++ b/mobile/lib/services/app_settings.service.dart @@ -88,7 +88,7 @@ enum AppSettingsEnum { photoManagerCustomFilter( StoreKey.photoManagerCustomFilter, null, - false, + true, ), ; diff --git a/mobile/lib/utils/migration.dart b/mobile/lib/utils/migration.dart index 6bcf92d402..3ec8ce5bbc 100644 --- a/mobile/lib/utils/migration.dart +++ b/mobile/lib/utils/migration.dart @@ -23,7 +23,7 @@ import 'package:isar/isar.dart'; // ignore: import_rule_photo_manager import 'package:photo_manager/photo_manager.dart'; -const int targetVersion = 12; +const int targetVersion = 13; Future migrateDatabaseIfNeeded(Isar db) async { final int version = Store.get(StoreKey.version, targetVersion); @@ -56,14 +56,18 @@ Future migrateDatabaseIfNeeded(Isar db) async { await drift.close(); } + if (version < 13) { + await Store.put(StoreKey.photoManagerCustomFilter, true); + } + + if (targetVersion >= 12) { + await Store.put(StoreKey.version, targetVersion); + return; + } + final shouldTruncate = version < 8 || version < targetVersion; if (shouldTruncate) { - if (targetVersion == 12) { - await Store.put(StoreKey.version, targetVersion); - return; - } - await _migrateTo(db, targetVersion); } }