From 2969e25ff71c6a1e7c298ce877195a2f39bcf5f5 Mon Sep 17 00:00:00 2001 From: Adam O'neill <78691968+AdamT20054@users.noreply.github.com> Date: Wed, 26 Feb 2025 17:48:18 +0000 Subject: [PATCH] fix: websockets calling on_new_release across all sessions upon new websocket connection. (#16339) * Implemented possible fix for the new_release window re-appearing across all active sessions when a new websocket connection is established. * Reverted websocket.ts Changes not needed to websocket.ts - was bouncing between ideas, current implementation doesn't need this to change. * Prettier test format. * Spelling (Aknowledged --> Acknowledged) --- .../shared-components/version-announcement-box.svelte | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/web/src/lib/components/shared-components/version-announcement-box.svelte b/web/src/lib/components/shared-components/version-announcement-box.svelte index 62e9baf779..9bfebe317e 100644 --- a/web/src/lib/components/shared-components/version-announcement-box.svelte +++ b/web/src/lib/components/shared-components/version-announcement-box.svelte @@ -14,6 +14,7 @@ const onAcknowledge = () => { localStorage.setItem('appVersion', releaseVersion); + sessionStorage.setItem('modalAcknowledged', 'true'); showModal = false; }; @@ -31,7 +32,7 @@ let releaseVersion = $derived($release && semverToName($release.releaseVersion)); let serverVersion = $derived($release && semverToName($release.serverVersion)); $effect(() => { - if ($release?.isAvailable) { + if ($release?.isAvailable && !sessionStorage.getItem('modalAcknowledged')) { handleRelease(); } });