From 2d0c39ed04f4d3853951932ca1ae28f60220902d Mon Sep 17 00:00:00 2001 From: mertalev <101130780+mertalev@users.noreply.github.com> Date: Mon, 11 Aug 2025 02:32:42 -0400 Subject: [PATCH] update constants --- mobile/lib/constants/constants.dart | 4 ---- .../presentation/widgets/images/local_image_provider.dart | 4 ++-- .../lib/presentation/widgets/images/thumbnail.widget.dart | 8 ++++---- .../widgets/images/thumbnail_tile.widget.dart | 4 ++-- mobile/lib/presentation/widgets/timeline/constants.dart | 2 +- 5 files changed, 9 insertions(+), 13 deletions(-) diff --git a/mobile/lib/constants/constants.dart b/mobile/lib/constants/constants.dart index 75e3cf207d..63af4ffff8 100644 --- a/mobile/lib/constants/constants.dart +++ b/mobile/lib/constants/constants.dart @@ -1,5 +1,3 @@ -import 'dart:ui'; - const int noDbId = -9223372036854775808; // from Isar const double downloadCompleted = -1; const double downloadFailed = -2; @@ -30,8 +28,6 @@ const String kDownloadGroupLivePhoto = 'group_livephoto'; const int kTimelineNoneSegmentSize = 120; const int kTimelineAssetLoadBatchSize = 1024; const int kTimelineAssetLoadOppositeSize = 64; -const Size kTimelineThumbnailTileSize = Size.square(256.0); -const Size kTimelineThumbnailSize = Size.square(256.0); const int kTimelineImageCacheMemory = 200 * 1024 * 1024; // Widget keys diff --git a/mobile/lib/presentation/widgets/images/local_image_provider.dart b/mobile/lib/presentation/widgets/images/local_image_provider.dart index 2671c11f75..5098ab98e7 100644 --- a/mobile/lib/presentation/widgets/images/local_image_provider.dart +++ b/mobile/lib/presentation/widgets/images/local_image_provider.dart @@ -3,16 +3,16 @@ import 'dart:ui'; import 'package:flutter/foundation.dart'; import 'package:flutter/widgets.dart'; -import 'package:immich_mobile/constants/constants.dart'; import 'package:immich_mobile/infrastructure/repositories/asset_media.repository.dart'; import 'package:immich_mobile/presentation/widgets/images/image_provider.dart'; import 'package:immich_mobile/presentation/widgets/images/one_frame_multi_image_stream_completer.dart'; +import 'package:immich_mobile/presentation/widgets/timeline/constants.dart'; class LocalThumbProvider extends ImageProvider with CancellableImageProviderMixin { final String id; final Size size; - LocalThumbProvider({required this.id, this.size = kTimelineThumbnailSize}); + LocalThumbProvider({required this.id, this.size = kThumbnailResolution}); @override Future obtainKey(ImageConfiguration configuration) { diff --git a/mobile/lib/presentation/widgets/images/thumbnail.widget.dart b/mobile/lib/presentation/widgets/images/thumbnail.widget.dart index 7ffbb6a9c8..b6d7153254 100644 --- a/mobile/lib/presentation/widgets/images/thumbnail.widget.dart +++ b/mobile/lib/presentation/widgets/images/thumbnail.widget.dart @@ -5,7 +5,6 @@ import 'dart:ui'; import 'package:flutter/material.dart'; import 'package:flutter/scheduler.dart'; -import 'package:immich_mobile/constants/constants.dart'; import 'package:immich_mobile/domain/models/asset/base_asset.model.dart'; import 'package:immich_mobile/entities/asset.entity.dart'; import 'package:immich_mobile/extensions/build_context_extensions.dart'; @@ -13,6 +12,7 @@ import 'package:immich_mobile/extensions/theme_extensions.dart'; import 'package:immich_mobile/presentation/widgets/images/image_provider.dart'; import 'package:immich_mobile/presentation/widgets/images/local_image_provider.dart'; import 'package:immich_mobile/presentation/widgets/images/remote_image_provider.dart'; +import 'package:immich_mobile/presentation/widgets/timeline/constants.dart'; import 'package:logging/logging.dart'; import 'package:thumbhash/thumbhash.dart' as thumbhash; @@ -30,7 +30,7 @@ class Thumbnail extends StatefulWidget { const Thumbnail({ this.imageProvider, this.fit = BoxFit.cover, - this.size = kTimelineThumbnailSize, + this.size = kThumbnailResolution, this.blurhash, this.thumbhashMode = ThumbhashMode.enabled, super.key, @@ -39,7 +39,7 @@ class Thumbnail extends StatefulWidget { Thumbnail.fromAsset({ required Asset asset, this.fit = BoxFit.cover, - this.size = kTimelineThumbnailSize, + this.size = kThumbnailResolution, this.thumbhashMode = ThumbhashMode.enabled, super.key, }) : blurhash = asset.thumbhash, @@ -48,7 +48,7 @@ class Thumbnail extends StatefulWidget { Thumbnail.fromBaseAsset({ required BaseAsset? asset, this.fit = BoxFit.cover, - this.size = kTimelineThumbnailSize, + this.size = kThumbnailResolution, this.thumbhashMode = ThumbhashMode.enabled, super.key, }) : blurhash = switch (asset) { diff --git a/mobile/lib/presentation/widgets/images/thumbnail_tile.widget.dart b/mobile/lib/presentation/widgets/images/thumbnail_tile.widget.dart index 1634a1df5d..d9802aa200 100644 --- a/mobile/lib/presentation/widgets/images/thumbnail_tile.widget.dart +++ b/mobile/lib/presentation/widgets/images/thumbnail_tile.widget.dart @@ -1,13 +1,13 @@ import 'package:auto_route/auto_route.dart'; import 'package:flutter/material.dart'; import 'package:hooks_riverpod/hooks_riverpod.dart'; -import 'package:immich_mobile/constants/constants.dart'; import 'package:immich_mobile/domain/models/asset/base_asset.model.dart'; import 'package:immich_mobile/domain/models/setting.model.dart'; import 'package:immich_mobile/extensions/build_context_extensions.dart'; import 'package:immich_mobile/extensions/duration_extensions.dart'; import 'package:immich_mobile/extensions/theme_extensions.dart'; import 'package:immich_mobile/presentation/widgets/images/thumbnail.widget.dart'; +import 'package:immich_mobile/presentation/widgets/timeline/constants.dart'; import 'package:immich_mobile/providers/infrastructure/setting.provider.dart'; import 'package:immich_mobile/presentation/widgets/timeline/timeline.state.dart'; import 'package:immich_mobile/providers/timeline/multiselect.provider.dart'; @@ -15,7 +15,7 @@ import 'package:immich_mobile/providers/timeline/multiselect.provider.dart'; class ThumbnailTile extends ConsumerWidget { const ThumbnailTile( this.asset, { - this.size = kTimelineThumbnailTileSize, + this.size = kTimelineFixedTileExtent, this.fit = BoxFit.cover, this.showStorageIndicator, this.lockSelection = false, diff --git a/mobile/lib/presentation/widgets/timeline/constants.dart b/mobile/lib/presentation/widgets/timeline/constants.dart index e3bb5fe273..242c9bb14e 100644 --- a/mobile/lib/presentation/widgets/timeline/constants.dart +++ b/mobile/lib/presentation/widgets/timeline/constants.dart @@ -2,7 +2,7 @@ import 'dart:ui'; const double kTimelineHeaderExtent = 80.0; const Size kTimelineFixedTileExtent = Size.square(256); -const Size kThumbnailResolution = kTimelineFixedTileExtent; +const Size kThumbnailResolution = Size.square(384); const double kTimelineSpacing = 2.0; const int kTimelineColumnCount = 3;