Cutlery/immich
1
0
Fork 1
mirror of https://github.com/immich-app/immich.git synced 2025-08-30 23:02:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: cannot load thumbnail from unknown content length (#21192)

Browse Source 
* fix: cannot load thumbnail from unknown content length

* pr feedback

* pr feedback
This commit is contained in:
Alex 2025-08-23 15:25:12 -05:00 committed by GitHub
parent f8b41ea8aa
commit 3138048b96
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 40 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
mobile/lib/infrastructure/loaders/remote_image_request.dart
View File

@ -64,18 +64,48 @@ class RemoteImageRequest extends ImageRequest {
if (_isCancelled) { if (_isCancelled) {
return null; return null;
} }
final bytes = Uint8List(response.contentLength);
// Handle unknown content length from reverse proxy
final contentLength = response.contentLength;
final Uint8List bytes;
int offset = 0; int offset = 0;
final subscription = response.listen((List<int> chunk) {
// this is important to break the response stream if the request is cancelled if (contentLength >= 0) {
if (_isCancelled) { // Known content length - use pre-allocated buffer
throw StateError('Cancelled request'); bytes = Uint8List(contentLength);
final subscription = response.listen((List<int> chunk) {
// this is important to break the response stream if the request is cancelled
if (_isCancelled) {
throw StateError('Cancelled request');
}
bytes.setAll(offset, chunk);
offset += chunk.length;
}, cancelOnError: true);
cacheManager?.putStreamedFile(url, response);
await subscription.asFuture();
} else {
// Unknown content length - collect chunks dynamically
final chunks = <List<int>>[];
int totalLength = 0;
final subscription = response.listen((List<int> chunk) {
// this is important to break the response stream if the request is cancelled
if (_isCancelled) {
throw StateError('Cancelled request');
}
chunks.add(chunk);
totalLength += chunk.length;
}, cancelOnError: true);
cacheManager?.putStreamedFile(url, response);
await subscription.asFuture();
// Combine all chunks into a single buffer
bytes = Uint8List(totalLength);
for (final chunk in chunks) {
bytes.setAll(offset, chunk);
offset += chunk.length;
} }
bytes.setAll(offset, chunk); }
offset += chunk.length;
}, cancelOnError: true);
cacheManager?.putStreamedFile(url, response);
await subscription.asFuture();
return await ImmutableBuffer.fromUint8List(bytes); return await ImmutableBuffer.fromUint8List(bytes);
} }