Cutlery/immich
1
0
Fork 1
mirror of https://github.com/immich-app/immich.git synced 2025-06-03 13:44:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat(web): make asset grid row height responsive (#16970)"

Browse Source 
This reverts commit 7075c5b39348431b476064c65772beec4ccc679c.
This commit is contained in:
Alex Tran 2025-03-26 09:08:23 -05:00
parent 6ba94ac2f2
commit 34aa6c1329
2 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web/src/lib/components/shared-components/gallery-viewer/gallery-viewer.svelte
View File

@ -63,14 +63,11 @@
const _assets = assets; const _assets = assets;
updateSlidingWindow(); updateSlidingWindow();
const rowWidth = Math.floor(viewport.width);
const rowHeight = rowWidth < 850 ? 100 : 235;
geometry = getJustifiedLayoutFromAssets(_assets, { geometry = getJustifiedLayoutFromAssets(_assets, {
spacing: 2, spacing: 2,
heightTolerance: 0.15, heightTolerance: 0.15,
rowHeight, rowHeight: 235,
rowWidth, rowWidth: Math.floor(viewport.width),
}); });
}); });

14
web/src/lib/stores/assets-store.svelte.ts
View File

@ -39,9 +39,7 @@ export type AssetStoreOptions = Omit<AssetApiGetTimeBucketsRequest, 'size'> & {
timelineAlbumId?: string; timelineAlbumId?: string;
deferInit?: boolean; deferInit?: boolean;
}; };
export type AssetStoreLayoutOptions = {
rowHeight: number;
};
// eslint-disable-next-line @typescript-eslint/no-explicit-any // eslint-disable-next-line @typescript-eslint/no-explicit-any
function updateObject(target: any, source: any): boolean { function updateObject(target: any, source: any): boolean {
if (!target) { if (!target) {
@ -578,7 +576,6 @@ export class AssetStore {
// --- private // --- private
static #INIT_OPTIONS = {}; static #INIT_OPTIONS = {};
#rowHeight = 235;
#viewportHeight = $state(0); #viewportHeight = $state(0);
#viewportWidth = $state(0); #viewportWidth = $state(0);
#scrollTop = $state(0); #scrollTop = $state(0);
@ -621,7 +618,6 @@ export class AssetStore {
const changed = value !== this.#viewportWidth; const changed = value !== this.#viewportWidth;
this.#viewportWidth = value; this.#viewportWidth = value;
this.suspendTransitions = true; this.suspendTransitions = true;
this.#rowHeight = value < 850 ? 100 : 235;
// side-effect - its ok! // side-effect - its ok!
void this.#updateViewportGeometry(changed); void this.#updateViewportGeometry(changed);
} }
@ -797,11 +793,6 @@ export class AssetStore {
this.#updateViewportGeometry(false); this.#updateViewportGeometry(false);
} }
updateLayoutOptions(options: AssetStoreLayoutOptions) {
this.#rowHeight = options.rowHeight;
this.refreshLayout();
}
async #init(options: AssetStoreOptions) { async #init(options: AssetStoreOptions) {
// doing the following outside of the task reduces flickr // doing the following outside of the task reduces flickr
this.isInitialized = false; this.isInitialized = false;
@ -871,11 +862,10 @@ export class AssetStore {
createLayoutOptions() { createLayoutOptions() {
const viewportWidth = this.viewportWidth; const viewportWidth = this.viewportWidth;
return { return {
spacing: 2, spacing: 2,
heightTolerance: 0.15, heightTolerance: 0.15,
rowHeight: this.#rowHeight, rowHeight: 235,
rowWidth: Math.floor(viewportWidth), rowWidth: Math.floor(viewportWidth),
}; };
} }