From 53f80393bf1045716d896a9367db24679fe37724 Mon Sep 17 00:00:00 2001
From: Daniel Dietzler <36593685+danieldietzler@users.noreply.github.com>
Date: Tue, 1 Jul 2025 12:47:04 +0200
Subject: [PATCH] chore: upgrade to cron v4 (#19664)

---
 server/package-lock.json                   | 40 ++++++++--------------
 server/package.json                        |  4 +--
 server/src/repositories/cron.repository.ts |  2 +-
 3 files changed, 17 insertions(+), 29 deletions(-)

diff --git a/server/package-lock.json b/server/package-lock.json
index 5e4f9a6fe1..3243444915 100644
--- a/server/package-lock.json
+++ b/server/package-lock.json
@@ -15,7 +15,7 @@
         "@nestjs/event-emitter": "^3.0.0",
         "@nestjs/platform-express": "^11.0.4",
         "@nestjs/platform-socket.io": "^11.0.4",
-        "@nestjs/schedule": "^5.0.0",
+        "@nestjs/schedule": "^6.0.0",
         "@nestjs/swagger": "^11.0.2",
         "@nestjs/websockets": "^11.0.4",
         "@opentelemetry/api": "^1.9.0",
@@ -44,7 +44,7 @@
         "compression": "^1.8.0",
         "cookie": "^1.0.2",
         "cookie-parser": "^1.4.7",
-        "cron": "^3.5.0",
+        "cron": "4.3.0",
         "exiftool-vendored": "^28.8.0",
         "express": "^5.1.0",
         "fast-glob": "^3.3.2",
@@ -2902,12 +2902,12 @@
       }
     },
     "node_modules/@nestjs/schedule": {
-      "version": "5.0.1",
-      "resolved": "https://registry.npmjs.org/@nestjs/schedule/-/schedule-5.0.1.tgz",
-      "integrity": "sha512-kFoel84I4RyS2LNPH6yHYTKxB16tb3auAEciFuc788C3ph6nABkUfzX5IE+unjVaRX+3GuruJwurNepMlHXpQg==",
+      "version": "6.0.0",
+      "resolved": "https://registry.npmjs.org/@nestjs/schedule/-/schedule-6.0.0.tgz",
+      "integrity": "sha512-aQySMw6tw2nhitELXd3EiRacQRgzUKD9mFcUZVOJ7jPLqIBvXOyvRWLsK9SdurGA+jjziAlMef7iB5ZEFFoQpw==",
       "license": "MIT",
       "dependencies": {
-        "cron": "3.5.0"
+        "cron": "4.3.0"
       },
       "peerDependencies": {
         "@nestjs/common": "^10.0.0 || ^11.0.0",
@@ -8645,13 +8645,16 @@
       }
     },
     "node_modules/cron": {
-      "version": "3.5.0",
-      "resolved": "https://registry.npmjs.org/cron/-/cron-3.5.0.tgz",
-      "integrity": "sha512-0eYZqCnapmxYcV06uktql93wNWdlTmmBFP2iYz+JPVcQqlyFYcn1lFuIk4R54pkOmE7mcldTAPZv6X5XA4Q46A==",
+      "version": "4.3.0",
+      "resolved": "https://registry.npmjs.org/cron/-/cron-4.3.0.tgz",
+      "integrity": "sha512-ciiYNLfSlF9MrDqnbMdRWFiA6oizSF7kA1osPP9lRzNu0Uu+AWog1UKy7SkckiDY2irrNjeO6qLyKnXC8oxmrw==",
       "license": "MIT",
       "dependencies": {
-        "@types/luxon": "~3.4.0",
-        "luxon": "~3.5.0"
+        "@types/luxon": "~3.6.0",
+        "luxon": "~3.6.0"
+      },
+      "engines": {
+        "node": ">=18.x"
       }
     },
     "node_modules/cron-parser": {
@@ -8666,21 +8669,6 @@
         "node": ">=12.0.0"
       }
     },
-    "node_modules/cron/node_modules/@types/luxon": {
-      "version": "3.4.2",
-      "resolved": "https://registry.npmjs.org/@types/luxon/-/luxon-3.4.2.tgz",
-      "integrity": "sha512-TifLZlFudklWlMBfhubvgqTXRzLDI5pCbGa4P8a3wPyUQSW+1xQ5eDsreP9DWHX3tjq1ke96uYG/nwundroWcA==",
-      "license": "MIT"
-    },
-    "node_modules/cron/node_modules/luxon": {
-      "version": "3.5.0",
-      "resolved": "https://registry.npmjs.org/luxon/-/luxon-3.5.0.tgz",
-      "integrity": "sha512-rh+Zjr6DNfUYR3bPwJEnuwDdqMbxZW7LOQfUN4B54+Cl+0o5zaU9RJ6bcidfDtC1cWCZXQ+nvX8bf6bAji37QQ==",
-      "license": "MIT",
-      "engines": {
-        "node": ">=12"
-      }
-    },
     "node_modules/cross-spawn": {
       "version": "7.0.6",
       "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.6.tgz",
diff --git a/server/package.json b/server/package.json
index cb234ab20a..ab8424329f 100644
--- a/server/package.json
+++ b/server/package.json
@@ -40,7 +40,7 @@
     "@nestjs/event-emitter": "^3.0.0",
     "@nestjs/platform-express": "^11.0.4",
     "@nestjs/platform-socket.io": "^11.0.4",
-    "@nestjs/schedule": "^5.0.0",
+    "@nestjs/schedule": "^6.0.0",
     "@nestjs/swagger": "^11.0.2",
     "@nestjs/websockets": "^11.0.4",
     "@opentelemetry/api": "^1.9.0",
@@ -69,7 +69,7 @@
     "compression": "^1.8.0",
     "cookie": "^1.0.2",
     "cookie-parser": "^1.4.7",
-    "cron": "^3.5.0",
+    "cron": "4.3.0",
     "exiftool-vendored": "^28.8.0",
     "express": "^5.1.0",
     "fast-glob": "^3.3.2",
diff --git a/server/src/repositories/cron.repository.ts b/server/src/repositories/cron.repository.ts
index e6e8fe7568..03fecca9ad 100644
--- a/server/src/repositories/cron.repository.ts
+++ b/server/src/repositories/cron.repository.ts
@@ -58,7 +58,7 @@ export class CronRepository {
       if (start) {
         job.start();
       } else {
-        job.stop();
+        void job.stop();
       }
     }
   }