Cutlery/immich
1
0
Fork 1
mirror of https://github.com/immich-app/immich.git synced 2025-05-24 01:12:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add jre for make open-api

Browse Source
This commit is contained in:
Min Idzelis 2025-05-01 23:46:12 +00:00
parent 974953e371
commit 63fc137a3f
3 changed files with 23 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.devcontainer/devcontainer.json
View File

@ -15,7 +15,8 @@
"bluebrown.yamlfmt",
"vkrishna04.cspell-sync",
"vitest.explorer",
"ms-playwright.playwright"
"ms-playwright.playwright",
"ms-azuretools.vscode-docker"
]
}
},

31
docs/docs/developer/devcontainers.md
View File

@ -71,30 +71,33 @@ This must be added to the `.bash_profile` if your using bash, or equivalent for
### SSH Keys and Commit Signing
This section applies if you are using SSH Keys to access GitHub. In order to allow git from inside the devcontainer to access GitHub using your existing SSH keys, ensure that you have a SSH Agent running, and that SSH agent forwarding is allowed.
This section applies if you are using SSH Keys to access GitHub. In order to allow git from inside the devcontainer to access GitHub using your existing SSH keys, ensure that you have a SSH Agent running, and that SSH agent forwarding is allowed.
For instructions, see the [guide here.](https://code.visualstudio.com/remote/advancedcontainers/sharing-git-credentials)
For instructions, see the [guide here.](https://code.visualstudio.com/remote/advancedcontainers/sharing-git-credentials)
You can also use this SSH key as a signing key. To configure this, see the [guide here.](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key#telling-git-about-your-ssh-key)
You can also use this SSH key as a signing key. To configure this, see the [guide here.](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key#telling-git-about-your-ssh-key)
## Workflow
Please ensure you've read the [setup](/docs/developer/setup) information first.
Please ensure you've read the [setup](/docs/developer/setup) information first.
After you've configured or reviewed the environment variables as mentioned above, then you are ready to start development.
After you've configured or reviewed the environment variables as mentioned above, then you are ready to start development.
By default, the devcontainer will automatically perform a few tasks whenever it starts.
By default, the devcontainer will automatically perform a few tasks whenever it starts.
1) Runs `postCreate.sh` - this bash script will adjust permissions to the `node` user that the devcontainer runs as. It will also run `npm i` and `npm run build` in all of the packages: `open-api/typescript-sdk`, `web`, and `server`.
2. VSCode will autorun the `Immich Server and Web` task defined in `tasks.json`. This task depends on `Immich Web Server (Vite)` and `Immich API Server (Nest)`, which will both be started automatically.
3. VSCode will automatically forward the web ports, and the debug ports from each process. The first time the web server is started, a browser will automatically be opened on the `/` URL of the server (both in local and cloud environments)
1. Runs `postCreate.sh` - this bash script will adjust permissions to the `node` user that the devcontainer runs as. It will also run `npm i` and `npm run build` in all of the packages: `open-api/typescript-sdk`, `web`, and `server`.
The `Immich API Server (Nest)` task runs the "API server", watching and compiling chnages in the `/server` folder.
2) VSCode will autorun the `Immich Server and Web` task defined in `tasks.json`. This task depends on `Immich Web Server (Vite)` and `Immich API Server (Nest)`, which will both be started automatically.
3) VSCode will automatically forward the web ports, and the debug ports from each process. The first time the web server is started, a browser will automatically be opened on the `/` URL of the server (both in local and cloud environments)
The `Immich Web Server (Vite)` task runs the "Web server", watching and compiling chnages in the `/web` folder. The web server will automatically proxy the upstream `/api` server in this development.
The `Immich API Server (Nest)` task runs the "API server", watching and compiling chnages in the `/server` folder.
The `Immich Web Server (Vite)` task runs the "Web server", watching and compiling chnages in the `/web` folder. The web server will automatically proxy the upstream `/api` server in this development.
These two tasks combined replace the command
```
make dev
```
from the non devcontainer developer workflow.
make dev
```
from the non devcontainer developer workflow.

5
server/Dockerfile
View File

@ -18,7 +18,10 @@ ENTRYPOINT ["tini", "--", "/bin/sh"]
FROM dev AS dev-container
RUN apt-get install inetutils-ping sudo -y
RUN apt-get update && \
apt-get install inetutils-ping openjdk-11-jre-headless \
vim nano \
-y --no-install-recommends --fix-missing
RUN usermod -aG sudo node
RUN echo "node ALL=(ALL) NOPASSWD: ALL" >> /etc/sudoers
RUN mkdir -p /workspaces/immich