Cutlery/immich
1
0
Fork 1
mirror of https://github.com/immich-app/immich.git synced 2025-06-03 05:34:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(mobile): video player not updating state (#10220)

Browse Source 
* fix(mobile): video player not updating state

* unused code
This commit is contained in:
Alex 2024-06-12 12:43:01 -05:00 committed by GitHub
parent 47ef48e3c2
commit 67e98ed313
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mobile/lib/pages/common/video_viewer.page.dart
View File

@ -75,9 +75,7 @@ class VideoViewerPage extends HookConsumerWidget {
// Also sets the error if there is an error in the playback // Also sets the error if there is an error in the playback
void updateVideoPlayback() { void updateVideoPlayback() {
final videoPlayback = VideoPlaybackValue.fromController(controller); final videoPlayback = VideoPlaybackValue.fromController(controller);
if (!loopVideo) { ref.read(videoPlaybackValueProvider.notifier).value = videoPlayback;
ref.read(videoPlaybackValueProvider.notifier).value = videoPlayback;
}
final state = videoPlayback.state; final state = videoPlayback.state;
// Enable the WakeLock while the video is playing // Enable the WakeLock while the video is playing
@ -110,7 +108,9 @@ class VideoViewerPage extends HookConsumerWidget {
} }
// Subscribes to listener // Subscribes to listener
controller.addListener(updateVideoPlayback); Future.microtask(() {
controller.addListener(updateVideoPlayback);
});
return () { return () {
// Removes listener when we dispose // Removes listener when we dispose
controller.removeListener(updateVideoPlayback); controller.removeListener(updateVideoPlayback);

14
mobile/lib/providers/asset_viewer/video_player_controls_provider.dart
View File

@ -93,4 +93,18 @@ class VideoPlayerControls extends StateNotifier<VideoPlaybackControls> {
pause: !state.pause, pause: !state.pause,
); );
} }
void restart() {
state = VideoPlaybackControls(
position: 0,
mute: state.mute,
pause: true,
);
state = VideoPlaybackControls(
position: 0,
mute: state.mute,
pause: false,
);
}
} }

2
mobile/lib/widgets/asset_viewer/custom_video_player_controls.dart
View File

@ -64,6 +64,8 @@ class CustomVideoPlayerControls extends HookConsumerWidget {
final state = ref.read(videoPlaybackValueProvider).state; final state = ref.read(videoPlaybackValueProvider).state;
if (state == VideoPlaybackState.playing) { if (state == VideoPlaybackState.playing) {
ref.read(videoPlayerControlsProvider.notifier).pause(); ref.read(videoPlayerControlsProvider.notifier).pause();
} else if (state == VideoPlaybackState.completed) {
ref.read(videoPlayerControlsProvider.notifier).restart();
} else { } else {
ref.read(videoPlayerControlsProvider.notifier).play(); ref.read(videoPlayerControlsProvider.notifier).play();
} }