Cutlery/immich
1
0
Fork 1
mirror of https://github.com/immich-app/immich.git synced 2025-11-26 08:15:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: deep link to last asset (#23920)

Browse Source
This commit is contained in:
Min Idzelis 2025-11-17 15:12:07 -05:00 committed by GitHub
parent 15e00f82f0
commit 69880ee165
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
web/src/lib/components/timeline/Timeline.svelte
View File

@ -176,12 +176,24 @@
}; };
const scrollAndLoadAsset = async (assetId: string) => { const scrollAndLoadAsset = async (assetId: string) => {
try {
// This flag prevents layout deferral to fix scroll positioning issues.
// When layouts are deferred and we scroll to an asset at the end of the timeline,
// we can calculate the asset's position, but the scrollableElement's scrollHeight
// hasn't been updated yet to reflect the new layout. This creates a mismatch that
// breaks scroll positioning. By disabling layout deferral in this case, we maintain
// the performance benefits of deferred layouts while still supporting deep linking
// to assets at the end of the timeline.
timelineManager.isScrollingOnLoad = true;
const monthGroup = await timelineManager.findMonthGroupForAsset(assetId); const monthGroup = await timelineManager.findMonthGroupForAsset(assetId);
if (!monthGroup) { if (!monthGroup) {
return false; return false;
} }
scrollToAssetPosition(assetId, monthGroup); scrollToAssetPosition(assetId, monthGroup);
return true; return true;
} finally {
timelineManager.isScrollingOnLoad = false;
}
}; };
const scrollToAsset = (asset: TimelineAsset) => { const scrollToAsset = (asset: TimelineAsset) => {

2
web/src/lib/managers/timeline-manager/day-group.svelte.ts
View File

@ -140,7 +140,7 @@ export class DayGroup {
} }
layout(options: CommonLayoutOptions, noDefer: boolean) { layout(options: CommonLayoutOptions, noDefer: boolean) {
if (!noDefer && !this.monthGroup.intersecting) { if (!noDefer && !this.monthGroup.intersecting && !this.monthGroup.timelineManager.isScrollingOnLoad) {
this.#deferredLayout = true; this.#deferredLayout = true;
return; return;
} }

1
web/src/lib/managers/timeline-manager/timeline-manager.svelte.ts
View File

@ -61,6 +61,7 @@ export class TimelineManager extends VirtualScrollManager {
}); });
isInitialized = $state(false); isInitialized = $state(false);
isScrollingOnLoad = false;
months: MonthGroup[] = $state([]); months: MonthGroup[] = $state([]);
albumAssets: Set<string> = new SvelteSet(); albumAssets: Set<string> = new SvelteSet();
scrubberMonths: ScrubberMonth[] = $state([]); scrubberMonths: ScrubberMonth[] = $state([]);