From 6a4f48204d421aef6d8eefdfa1bf9da3f0b51420 Mon Sep 17 00:00:00 2001 From: Jason Rasmussen Date: Fri, 14 Feb 2025 11:36:01 -0500 Subject: [PATCH] chore: pr feedback --- server/src/repositories/metadata.repository.ts | 5 ++++- .../components/asset-viewer/actions/rotate-action.svelte | 8 ++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/server/src/repositories/metadata.repository.ts b/server/src/repositories/metadata.repository.ts index ae7be5e5f4..791dd2bae6 100644 --- a/server/src/repositories/metadata.repository.ts +++ b/server/src/repositories/metadata.repository.ts @@ -1,6 +1,7 @@ import { Injectable } from '@nestjs/common'; import { BinaryField, DefaultReadTaskOptions, ExifTool, Tags } from 'exiftool-vendored'; import geotz from 'geo-tz'; +import { LogLevel } from 'src/enum'; import { LoggingRepository } from 'src/repositories/logging.repository'; interface ExifDuration { @@ -101,7 +102,9 @@ export class MetadataRepository { } async writeTags(path: string, tags: Partial): Promise { - this.logger.verbose(`Writing tags ${JSON.stringify(tags)} to ${path}`); + if (this.logger.isLevelEnabled(LogLevel.VERBOSE)) { + this.logger.verbose(`Writing tags ${JSON.stringify(tags)} to ${path}`); + } try { await this.exiftool.write(path, tags); } catch (error) { diff --git a/web/src/lib/components/asset-viewer/actions/rotate-action.svelte b/web/src/lib/components/asset-viewer/actions/rotate-action.svelte index a0c5bcaf4e..2b36c4e72c 100644 --- a/web/src/lib/components/asset-viewer/actions/rotate-action.svelte +++ b/web/src/lib/components/asset-viewer/actions/rotate-action.svelte @@ -60,8 +60,12 @@ }; const handleRotate = async () => { - const current = Number(asset.exifInfo?.orientation); - if (!current && current !== 0) { + if (!asset.exifInfo?.orientation) { + return; + } + + const current = Number(asset.exifInfo.orientation); + if (Number.isNaN(current)) { return; }